Browse Source

Make copy and multipart test jobs fail instead of succeed

Changed exit 0 to exit 1 for s3-sse-copy-operations and s3-sse-multipart
jobs. These jobs document known limitations but should fail to ensure
the issues are tracked and addressed, not silently ignored.
pull/7890/head
Chris Lu 3 days ago
parent
commit
bc34a7eb3c
  1. 6
      .github/workflows/s3-sse-tests.yml

6
.github/workflows/s3-sse-tests.yml

@ -237,7 +237,8 @@ jobs:
echo " - SSE-C copy operations: HTTP 500 errors (pre-existing functionality gap)" echo " - SSE-C copy operations: HTTP 500 errors (pre-existing functionality gap)"
echo " - Cross-encryption security fix: ✅ Implemented and tested (forces streaming copy)" echo " - Cross-encryption security fix: ✅ Implemented and tested (forces streaming copy)"
echo " - These limitations are documented as pre-existing issues" echo " - These limitations are documented as pre-existing issues"
exit 0 # Job succeeds with security fix preserved and limitations documented
echo "❌ Failing job to ensure these limitations are addressed in the future"
exit 1 # Job fails to ensure known limitations are tracked and addressed
- name: Upload server logs on failure - name: Upload server logs on failure
if: failure() if: failure()
@ -286,7 +287,8 @@ jobs:
echo " - SSE-C multipart GET operations: HTTP 500 errors (pre-existing functionality gap)" echo " - SSE-C multipart GET operations: HTTP 500 errors (pre-existing functionality gap)"
echo " - SSE-KMS multipart decryption: Requires per-chunk SSE metadata architecture changes" echo " - SSE-KMS multipart decryption: Requires per-chunk SSE metadata architecture changes"
echo " - These limitations are documented and require future architectural work" echo " - These limitations are documented and require future architectural work"
exit 0 # Job succeeds with clear documentation of known limitations
echo "❌ Failing job to ensure these limitations are addressed in the future"
exit 1 # Job fails to ensure known limitations are tracked and addressed
- name: Upload server logs on failure - name: Upload server logs on failure
if: failure() if: failure()

Loading…
Cancel
Save