From bc34a7eb3c103ae7ab2000da2a6c3925712eb226 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Fri, 26 Dec 2025 18:15:21 -0800 Subject: [PATCH] Make copy and multipart test jobs fail instead of succeed Changed exit 0 to exit 1 for s3-sse-copy-operations and s3-sse-multipart jobs. These jobs document known limitations but should fail to ensure the issues are tracked and addressed, not silently ignored. --- .github/workflows/s3-sse-tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/s3-sse-tests.yml b/.github/workflows/s3-sse-tests.yml index 2a8c0b332..97d32358f 100644 --- a/.github/workflows/s3-sse-tests.yml +++ b/.github/workflows/s3-sse-tests.yml @@ -237,7 +237,8 @@ jobs: echo " - SSE-C copy operations: HTTP 500 errors (pre-existing functionality gap)" echo " - Cross-encryption security fix: ✅ Implemented and tested (forces streaming copy)" echo " - These limitations are documented as pre-existing issues" - exit 0 # Job succeeds with security fix preserved and limitations documented + echo "❌ Failing job to ensure these limitations are addressed in the future" + exit 1 # Job fails to ensure known limitations are tracked and addressed - name: Upload server logs on failure if: failure() @@ -286,7 +287,8 @@ jobs: echo " - SSE-C multipart GET operations: HTTP 500 errors (pre-existing functionality gap)" echo " - SSE-KMS multipart decryption: Requires per-chunk SSE metadata architecture changes" echo " - These limitations are documented and require future architectural work" - exit 0 # Job succeeds with clear documentation of known limitations + echo "❌ Failing job to ensure these limitations are addressed in the future" + exit 1 # Job fails to ensure known limitations are tracked and addressed - name: Upload server logs on failure if: failure()