Browse Source

Change bucket creation errors from skip to fatal

Tests should fail, not skip, when bucket creation fails. This ensures
that credential mismatches and other configuration issues are caught
rather than silently skipped.
pull/7890/head
Chris Lu 2 days ago
parent
commit
096072ca60
  1. 8
      test/s3/sse/s3_volume_encryption_test.go

8
test/s3/sse/s3_volume_encryption_test.go

@ -35,7 +35,7 @@ func TestS3VolumeEncryptionRoundtrip(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket (server may not be running): %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)
@ -127,7 +127,7 @@ func TestS3VolumeEncryptionMultiChunk(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket: %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)
@ -223,7 +223,7 @@ func TestS3VolumeEncryptionMultiChunkRangeRead(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket: %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)
@ -347,7 +347,7 @@ func TestS3VolumeEncryptionCopy(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket: %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)

Loading…
Cancel
Save