You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tree: 3d7a65c7e5

add-admin-and-worker-to-helm-charts

add-ec-vacuum

add_fasthttp_client

add_remote_storage

adding-message-queue-integration-tests

also-delete-parent-directory-if-empty

avoid_releasing_temp_file_on_write

changing-to-zap

collect-public-metrics

create-table-snapshot-api-design

data_query_pushdown

dependabot/maven/other/java/client/com.google.protobuf-protobuf-java-3.25.5

dependabot/maven/other/java/examples/org.apache.hadoop-hadoop-common-3.4.0

detect-and-plan-ec-tasks

do-not-retry-if-error-is-NotFound

enhance-erasure-coding

fasthttp

filer1_maintenance_branch

fix-GetObjectLockConfigurationHandler

fix-versioning-listing-only

ftp

gh-pages

improve-fuse-mount

improve-fuse-mount2

logrus

master

message_send

mount2

mq-subscribe

mq2

original_weed_mount

pr-7412

random_access_file

refactor-needle-read-operations

refactor-volume-write

remote_overlay

revert-5134-patch-1

revert-5819-patch-1

revert-6434-bugfix-missing-s3-audit

s3-select

sub

tcp_read

test-reverting-lock-table

test_udp

testing

testing-sdx-generation

tikv

track-mount-e2e

upgrade-versions-to-4.00

volume_buffered_writes

worker-execute-ec-tasks

0.72

0.72.release

0.73

0.74

0.75

0.76

0.77

0.90

0.91

0.92

0.93

0.94

0.95

0.96

0.97

0.98

0.99

1.00

1.01

1.02

1.03

1.04

1.05

1.06

1.07

1.08

1.09

1.10

1.11

1.12

1.14

1.15

1.16

1.17

1.18

1.19

1.20

1.21

1.22

1.23

1.24

1.25

1.26

1.27

1.28

1.29

1.30

1.31

1.32

1.33

1.34

1.35

1.36

1.37

1.38

1.40

1.41

1.42

1.43

1.44

1.45

1.46

1.47

1.48

1.49

1.50

1.51

1.52

1.53

1.54

1.55

1.56

1.57

1.58

1.59

1.60

1.61

1.61RC

1.62

1.63

1.64

1.65

1.66

1.67

1.68

1.69

1.70

1.71

1.72

1.73

1.74

1.75

1.76

1.77

1.78

1.79

1.80

1.81

1.82

1.83

1.84

1.85

1.86

1.87

1.88

1.90

1.91

1.92

1.93

1.94

1.95

1.96

1.97

1.98

1.99

1;70

2.00

2.01

2.02

2.03

2.04

2.05

2.06

2.07

2.08

2.09

2.10

2.11

2.12

2.13

2.14

2.15

2.16

2.17

2.18

2.19

2.20

2.21

2.22

2.23

2.24

2.25

2.26

2.27

2.28

2.29

2.30

2.31

2.32

2.33

2.34

2.35

2.36

2.37

2.38

2.39

2.40

2.41

2.42

2.43

2.47

2.48

2.49

2.50

2.51

2.52

2.53

2.54

2.55

2.56

2.57

2.58

2.59

2.60

2.61

2.62

2.63

2.64

2.65

2.66

2.67

2.68

2.69

2.70

2.71

2.72

2.73

2.74

2.75

2.76

2.77

2.78

2.79

2.80

2.81

2.82

2.83

2.84

2.85

2.86

2.87

2.88

2.89

2.90

2.91

2.92

2.93

2.94

2.95

2.96

2.97

2.98

2.99

3.00

3.01

3.02

3.03

3.04

3.05

3.06

3.07

3.08

3.09

3.10

3.11

3.12

3.13

3.14

3.15

3.16

3.18

3.19

3.20

3.21

3.22

3.23

3.24

3.25

3.26

3.27

3.28

3.29

3.30

3.31

3.32

3.33

3.34

3.35

3.36

3.37

3.38

3.39

3.40

3.41

3.42

3.43

3.44

3.45

3.46

3.47

3.48

3.50

3.51

3.52

3.53

3.54

3.55

3.56

3.57

3.58

3.59

3.60

3.61

3.62

3.63

3.64

3.65

3.66

3.67

3.68

3.69

3.71

3.72

3.73

3.74

3.75

3.76

3.77

3.78

3.79

3.80

3.81

3.82

3.83

3.84

3.85

3.86

3.87

3.88

3.89

3.90

3.91

3.92

3.93

3.94

3.95

3.96

3.97

3.98

3.99

4.00

4.01

dev

helm-3.65.1

v0.69

v0.70beta

v3.33

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from '3d7a65c7e5'

${ noResults }

seaweedfs/weed/filer

History

Chris Lu 1ce9826c36 Address CodeRabbit review: fix buffer reuse and improve lock safety Address two code review suggestions: 1. **Fix buffer reuse in ReadFilerConfFromFilers**: - Use local []byte data instead of shared buffer - Prevents partial data from failed attempts affecting successful reads - Creates fresh buffer inside callback for masterClient path - More robust to future changes in read helpers 2. **Improve lock safety in FilerClient**: - Add *WithHealth variants that accept health pointer - Get health pointer while holding lock, then release before calling - Eliminates potential for lock confusion (though no actual deadlock existed) - Clearer separation: lock for data access, atomics for health ops Changes: - ReadFilerConfFromFilers: var data []byte, create buf inside callback - shouldSkipUnhealthyFilerWithHealth(health *filerHealth) - recordFilerSuccessWithHealth(health *filerHealth) - recordFilerFailureWithHealth(health *filerHealth) - Keep old functions for backward compatibility (marked deprecated) - Update LookupVolumeIds to use WithHealth variants Benefits: - More robust multi-filer configuration reading - Clearer lock vs atomic operation boundaries - No lock held during health checks (even though atomics don't block) - Better code organization and maintainability		3 days ago
..
abstract_sql	Add error list each entry func (#7485)	3 days ago
arangodb	Add error list each entry func (#7485)	3 days ago
cassandra	Add error list each entry func (#7485)	3 days ago
cassandra2	Add error list each entry func (#7485)	3 days ago
elastic/v7	Add error list each entry func (#7485)	3 days ago
etcd	Add error list each entry func (#7485)	3 days ago
foundationdb	Add error list each entry func (#7485)	3 days ago
hbase	Add error list each entry func (#7485)	3 days ago
leveldb	Add error list each entry func (#7485)	3 days ago
leveldb2	Add error list each entry func (#7485)	3 days ago
leveldb3	Add error list each entry func (#7485)	3 days ago
mongodb	Add error list each entry func (#7485)	3 days ago
mysql	convert error fromating to %w everywhere (#6995)	4 months ago
mysql2	print only adapted url	2 years ago
postgres	Filer Store: postgres backend support pgbouncer (#7077)	4 months ago
postgres2	Filer Store: postgres backend support pgbouncer (#7077)	4 months ago
redis	Add error list each entry func (#7485)	3 days ago
redis2	Add error list each entry func (#7485)	3 days ago
redis3	Add error list each entry func (#7485)	3 days ago
redis_lua	Add error list each entry func (#7485)	3 days ago
rocksdb	Add error list each entry func (#7485)	3 days ago
sqlite	serialize sqlite operations	3 years ago
store_test	Add error list each entry func (#7485)	3 days ago
tarantool	Add error list each entry func (#7485)	3 days ago
tikv	Add error list each entry func (#7485)	3 days ago
ydb	Add error list each entry func (#7485)	3 days ago
configuration.go	add notes for full version	3 years ago
entry.go	do delete expired entries on s3 list request (#7426)	3 weeks ago
entry_codec.go	also migrate jsonpb	3 years ago
filechunk_group.go	Context cancellation during reading range reading large files (#7093)	4 months ago
filechunk_group_test.go	Context cancellation during reading range reading large files (#7093)	4 months ago
filechunk_manifest.go	Clients to volume server requires JWT tokens for all read operations (#7376)	1 month ago
filechunk_manifest_test.go	move to https://github.com/seaweedfs/seaweedfs	3 years ago
filechunk_section.go	Context cancellation during reading range reading large files (#7093)	4 months ago
filechunk_section_test.go	merge chunks during upload (#4130)	3 years ago
filechunks.go	Filer: fix filer range read (#7078)	4 months ago
filechunks2_test.go	Add context with request (#6824)	6 months ago
filechunks_read.go	"golang.org/x/exp/slices" => "slices" and go fmt	11 months ago
filechunks_read_test.go	more solid weed mount (#4089)	3 years ago
filechunks_test.go	S3 API: Advanced IAM System (#7160)	3 months ago
filer.go	Add error list each entry func (#7485)	3 days ago
filer_buckets.go	filer: remove replication, collection, disk_type info from entry metadata	4 years ago
filer_conf.go	Address CodeRabbit review: fix buffer reuse and improve lock safety	3 days ago
filer_conf_test.go	move to https://github.com/seaweedfs/seaweedfs	3 years ago
filer_delete_entry.go	convert error fromating to %w everywhere (#6995)	4 months ago
filer_deletion.go	Filer: Add retry mechanism for failed file deletions (#7402)	1 month ago
filer_deletion_test.go	Filer: Add retry mechanism for failed file deletions (#7402)	1 month ago
filer_hardlink.go	move to https://github.com/seaweedfs/seaweedfs	3 years ago
filer_notify.go	S3: Directly read write volume servers (#7481)	1 week ago
filer_notify_append.go	convert error fromating to %w everywhere (#6995)	4 months ago
filer_notify_read.go	Add Kafka Gateway (#7231)	2 months ago
filer_notify_test.go	refactor filer_pb.Entry and filer.Entry to use GetChunks()	3 years ago
filer_on_meta_event.go	Context cancellation during reading range reading large files (#7093)	4 months ago
filer_rename.go	Fix: http rename move dir to subdir (#4432)	3 years ago
filer_search.go	Add error list each entry func (#7485)	3 days ago
filerstore.go	Add error list each entry func (#7485)	3 days ago
filerstore_hardlink.go	Changes logging function (#6919)	5 months ago
filerstore_translate_path.go	Add error list each entry func (#7485)	3 days ago
filerstore_wrapper.go	Add error list each entry func (#7485)	3 days ago
interval_list.go	Mount concurrent read (#4400)	3 years ago
interval_list_test.go	more solid weed mount (#4089)	3 years ago
meta_aggregator.go	S3: Directly read write volume servers (#7481)	1 week ago
meta_replay.go	"golang.org/x/exp/slices" => "slices" and go fmt	11 months ago
read_remote.go	refactor filer_pb.Entry and filer.Entry to use GetChunks()	3 years ago
read_write.go	added context to filer_client method calls (#6808)	6 months ago
reader_at.go	S3: adds FilerClient to use cached volume id (#7518)	1 week ago
reader_at_test.go	Context cancellation during reading range reading large files (#7093)	4 months ago
reader_cache.go	Fixed weed mount reads with jwt.signing.read.key (#7061)	4 months ago
reader_pattern.go	Fix a few data races when reading files in mount (#3527)	3 years ago
remote_mapping.go	convert error fromating to %w everywhere (#6995)	4 months ago
remote_storage.go	chore(deps): bump github.com/viant/ptrie from 0.3.1 to 1.0.1 (#5552)	2 years ago
remote_storage_test.go	move to https://github.com/seaweedfs/seaweedfs	3 years ago
s3iam_conf.go	convert error fromating to %w everywhere (#6995)	4 months ago
s3iam_conf_test.go	s3: fix configuring IAM for the same user	3 years ago
stream.go	Clients to volume server requires JWT tokens for all read operations (#7376)	1 month ago
topics.go	merge current message queue code changes (#6201)	1 year ago