minor

weed/server/filer_server_handlers_write_autochunk.go

@@ -162,9 +162,10 @@ func (fs *FilerServer) saveMetaData(ctx context.Context, r *http.Request, fileNa
 	var entry *filer.Entry
 	var mergedChunks []*filer_pb.FileChunk
 
+	isAppend := isAppend(r)
 	isOffsetWrite := len(fileChunks) > 0 && fileChunks[0].Offset > 0
 	// when it is an append
-	if isAppend(r) || isOffsetWrite {
+	if isAppend || isOffsetWrite {
 		existingEntry, findErr := fs.filer.FindEntry(ctx, util.FullPath(path))
 		if findErr != nil && findErr != filer_pb.ErrNotFound {
 			glog.V(0).Infof("failing to find %s: %v", path, findErr)
@@ -175,7 +176,7 @@ func (fs *FilerServer) saveMetaData(ctx context.Context, r *http.Request, fileNa
 		entry.Mtime = time.Now()
 		entry.Md5 = nil
 		// adjust chunk offsets
-		if isAppend(r) {
+		if isAppend {
 			for _, chunk := range fileChunks {
 				chunk.Offset += int64(entry.FileSize)
 			}

weed/server/filer_server_handlers_write_upload.go

@@ -32,6 +32,7 @@ var bufPool = sync.Pool{
 func (fs *FilerServer) uploadReaderToChunks(w http.ResponseWriter, r *http.Request, reader io.Reader, chunkSize int32, fileName, contentType string, contentLength int64, so *operation.StorageOption) (fileChunks []*filer_pb.FileChunk, md5Hash hash.Hash, chunkOffset int64, uploadErr error, smallContent []byte) {
 	query := r.URL.Query()
 
+	isAppend := isAppend(r)
 	if query.Has("offset") {
 		offset := query.Get("offset")
 		offsetInt, err := strconv.ParseInt(offset, 10, 64)
@@ -39,7 +40,7 @@ func (fs *FilerServer) uploadReaderToChunks(w http.ResponseWriter, r *http.Reque
 			err = fmt.Errorf("invalid 'offset': '%s'", offset)
 			return nil, nil, 0, err, nil
 		}
-		if isAppend(r) && offsetInt > 0 {
+		if isAppend && offsetInt > 0 {
 			err = fmt.Errorf("cannot set offset when op=append")
 			return nil, nil, 0, err, nil
 		}
@@ -80,7 +81,7 @@ func (fs *FilerServer) uploadReaderToChunks(w http.ResponseWriter, r *http.Reque
 			bytesBufferLimitCond.Signal()
 			break
 		}
-		if chunkOffset == 0 && !isAppend(r) {
+		if chunkOffset == 0 && !isAppend {
 			if dataSize < fs.option.SaveToFilerLimit || strings.HasPrefix(r.URL.Path, filer.DirectoryEtcRoot) {
 				chunkOffset += dataSize
 				smallContent = make([]byte, dataSize)