Browse Source

Fix deadlock in lock table locks (#5566)

pull/5578/head
Patrick Schmidt 8 months ago
committed by GitHub
parent
commit
96c48bd0da
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 11
      weed/util/lock_table.go

11
weed/util/lock_table.go

@ -2,9 +2,10 @@ package util
import (
"fmt"
"github.com/seaweedfs/seaweedfs/weed/glog"
"sync"
"sync/atomic"
"github.com/seaweedfs/seaweedfs/weed/glog"
)
// LockTable is a table of locks that can be acquired.
@ -13,6 +14,7 @@ type LockTable[T comparable] struct {
lockIdSeq int64
mu sync.Mutex
locks map[T]*LockEntry
locksInFlight map[T]int
}
type LockEntry struct {
@ -40,6 +42,7 @@ type ActiveLock struct {
func NewLockTable[T comparable]() *LockTable[T] {
return &LockTable[T]{
locks: make(map[T]*LockEntry),
locksInFlight: make(map[T]int),
}
}
@ -57,7 +60,9 @@ func (lt *LockTable[T]) AcquireLock(intention string, key T, lockType LockType)
entry = &LockEntry{}
entry.cond = sync.NewCond(&entry.mu)
lt.locks[key] = entry
lt.locksInFlight[key] = 0
}
lt.locksInFlight[key]++
lt.mu.Unlock()
lock = lt.NewActiveLock(intention, lockType)
@ -120,6 +125,7 @@ func (lt *LockTable[T]) ReleaseLock(key T, lock *ActiveLock) {
return
}
lt.locksInFlight[key]--
entry.mu.Lock()
defer entry.mu.Unlock()
@ -139,8 +145,9 @@ func (lt *LockTable[T]) ReleaseLock(key T, lock *ActiveLock) {
}
// If there are no waiters, release the lock
if len(entry.waiters) == 0 && entry.activeExclusiveLockOwnerCount <= 0 && entry.activeSharedLockOwnerCount <= 0 {
if len(entry.waiters) == 0 && lt.locksInFlight[key] <= 0 && entry.activeExclusiveLockOwnerCount <= 0 && entry.activeSharedLockOwnerCount <= 0 {
delete(lt.locks, key)
delete(lt.locksInFlight, key)
}
if glog.V(4) {

Loading…
Cancel
Save