Browse Source

refactor(shell): readability improvements (#3704)

Signed-off-by: Ryan Russell <git@ryanrussell.org>

Signed-off-by: Ryan Russell <git@ryanrussell.org>
pull/3707/head
Ryan Russell 2 years ago
committed by GitHub
parent
commit
824f7ad9e1
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      weed/shell/command_fs_configure.go
  2. 2
      weed/shell/command_lock_unlock.go
  3. 2
      weed/shell/command_remote_meta_sync.go
  4. 2
      weed/shell/command_s3_circuitbreaker_test.go
  5. 2
      weed/shell/command_s3_clean_uploads.go

2
weed/shell/command_fs_configure.go

@ -98,7 +98,7 @@ func (c *commandFsConfigure) Do(args []string, commandEnv *CommandEnv, writer io
return fmt.Errorf("parse replication %s: %v", *replication, err)
}
if *volumeGrowthCount%rp.GetCopyCount() != 0 {
return fmt.Errorf("volumeGrowthCount %d should be devided by replication copy count %d", *volumeGrowthCount, rp.GetCopyCount())
return fmt.Errorf("volumeGrowthCount %d should be divided by replication copy count %d", *volumeGrowthCount, rp.GetCopyCount())
}
}

2
weed/shell/command_lock_unlock.go

@ -21,7 +21,7 @@ func (c *commandLock) Name() string {
func (c *commandLock) Help() string {
return `lock in order to exclusively manage the cluster
This is a blocking operation if there is alread another lock.
This is a blocking operation if there is already another lock.
`
}

2
weed/shell/command_remote_meta_sync.go

@ -96,7 +96,7 @@ After caching the file content, the entry.RemoteEntry will be
remoteEntry.LastLocalSyncTsNs == time.Now.UnixNano()
Attributes.FileSize = uint64(remoteEntry.RemoteSize)
Attributes.Mtime = remoteEntry.RemoteMtime
chunks = non-emtpy
chunks = non-empty
When "weed filer.remote.sync" to upload local changes to remote, the criteria is:

2
weed/shell/command_s3_circuitbreaker_test.go

@ -285,7 +285,7 @@ func TestCircuitBreakerShell(t *testing.T) {
t.Error(err)
}
if !reflect.DeepEqual(actual, expect) {
t.Fatal("result of s3 circuit breaker shell command is unexpect!")
t.Fatal("result of s3 circuit breaker shell command is unexpected!")
}
}
}

2
weed/shell/command_s3_clean_uploads.go

@ -60,7 +60,7 @@ func (c *commandS3CleanUploads) Do(args []string, commandEnv *CommandEnv, writer
for _, bucket := range buckets {
if err := c.cleanupUploads(commandEnv, writer, filerBucketsPath, bucket, *uploadedTimeAgo, signingKey); err != nil {
fmt.Fprintf(writer, fmt.Sprintf("failed cleanup uploads for backet %s: %v", bucket, err))
fmt.Fprintf(writer, fmt.Sprintf("failed cleanup uploads for bucket %s: %v", bucket, err))
}
}

Loading…
Cancel
Save