Browse Source

fix: update getVersioningState to signal non-existent buckets with ErrNotFound

This change modifies the getVersioningState function to return filer_pb.ErrNotFound when a requested bucket does not exist, allowing callers to handle the situation appropriately, such as auto-creating the bucket in PUT handlers. This improves error handling and clarity in the API's behavior regarding bucket existence.
pull/7613/head
洪晓威 16 hours ago
parent
commit
0ff6d8c31a
  1. 4
      weed/s3api/s3api_bucket_config.go

4
weed/s3api/s3api_bucket_config.go

@ -519,7 +519,9 @@ func (s3a *S3ApiServer) getVersioningState(bucket string) (string, error) {
config, errCode := s3a.getBucketConfig(bucket) config, errCode := s3a.getBucketConfig(bucket)
if errCode != s3err.ErrNone { if errCode != s3err.ErrNone {
if errCode == s3err.ErrNoSuchBucket { if errCode == s3err.ErrNoSuchBucket {
return "", nil
// Signal to callers that the bucket does not exist so they can
// decide whether to auto-create it (e.g., in PUT handlers).
return "", filer_pb.ErrNotFound
} }
glog.Errorf("getVersioningState: failed to get bucket config for %s: %v", bucket, errCode) glog.Errorf("getVersioningState: failed to get bucket config for %s: %v", bucket, errCode)
return "", fmt.Errorf("failed to get bucket config: %v", errCode) return "", fmt.Errorf("failed to get bucket config: %v", errCode)

Loading…
Cancel
Save