From 096072ca606daf15ecf0a2b6fb49569ed61ffb1b Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Fri, 26 Dec 2025 18:13:33 -0800 Subject: [PATCH] Change bucket creation errors from skip to fatal Tests should fail, not skip, when bucket creation fails. This ensures that credential mismatches and other configuration issues are caught rather than silently skipped. --- test/s3/sse/s3_volume_encryption_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/s3/sse/s3_volume_encryption_test.go b/test/s3/sse/s3_volume_encryption_test.go index df23c011b..a06d8dd91 100644 --- a/test/s3/sse/s3_volume_encryption_test.go +++ b/test/s3/sse/s3_volume_encryption_test.go @@ -35,7 +35,7 @@ func TestS3VolumeEncryptionRoundtrip(t *testing.T) { Bucket: aws.String(bucket), }) if err != nil { - t.Skipf("Skipping test - could not create bucket (server may not be running): %v", err) + t.Fatalf("Failed to create bucket: %v", err) } defer cleanupBucket(t, svc, bucket) @@ -127,7 +127,7 @@ func TestS3VolumeEncryptionMultiChunk(t *testing.T) { Bucket: aws.String(bucket), }) if err != nil { - t.Skipf("Skipping test - could not create bucket: %v", err) + t.Fatalf("Failed to create bucket: %v", err) } defer cleanupBucket(t, svc, bucket) @@ -223,7 +223,7 @@ func TestS3VolumeEncryptionMultiChunkRangeRead(t *testing.T) { Bucket: aws.String(bucket), }) if err != nil { - t.Skipf("Skipping test - could not create bucket: %v", err) + t.Fatalf("Failed to create bucket: %v", err) } defer cleanupBucket(t, svc, bucket) @@ -347,7 +347,7 @@ func TestS3VolumeEncryptionCopy(t *testing.T) { Bucket: aws.String(bucket), }) if err != nil { - t.Skipf("Skipping test - could not create bucket: %v", err) + t.Fatalf("Failed to create bucket: %v", err) } defer cleanupBucket(t, svc, bucket)