Browse Source

code review: no need for try-catch, a dummy localStorage is created if none exists

pull/2/head
gorhill 7 years ago
parent
commit
6aa8c856cf
No known key found for this signature in database GPG Key ID: 25E1490B761470C2
  1. 17
      src/js/popup.js

17
src/js/popup.js

@ -35,13 +35,8 @@
// Stuff which is good to do very early so as to avoid visual glitches. // Stuff which is good to do very early so as to avoid visual glitches.
(function() { (function() {
var paneContentPaddingTop,
touchDevice;
try {
paneContentPaddingTop = localStorage.getItem('paneContentPaddingTop');
var paneContentPaddingTop = localStorage.getItem('paneContentPaddingTop'),
touchDevice = localStorage.getItem('touchDevice'); touchDevice = localStorage.getItem('touchDevice');
} catch(ex) {
}
if ( typeof paneContentPaddingTop === 'string' ) { if ( typeof paneContentPaddingTop === 'string' ) {
document.querySelector('.paneContent').style.setProperty( document.querySelector('.paneContent').style.setProperty(
@ -55,10 +50,7 @@
document.addEventListener('touchstart', function onTouched(ev) { document.addEventListener('touchstart', function onTouched(ev) {
document.removeEventListener(ev.type, onTouched); document.removeEventListener(ev.type, onTouched);
document.body.setAttribute('data-touch', 'true'); document.body.setAttribute('data-touch', 'true');
try {
localStorage.setItem('touchDevice', 'true');
} catch(ex) {
}
localStorage.setItem('touchDevice', 'true');
resizePopup(); resizePopup();
}); });
} }
@ -75,10 +67,7 @@ var resizePopup = (function() {
paneContent = doc.querySelector('.paneContent'); paneContent = doc.querySelector('.paneContent');
if ( paddingTop !== paneContent.style.paddingTop ) { if ( paddingTop !== paneContent.style.paddingTop ) {
paneContent.style.setProperty('padding-top', paddingTop); paneContent.style.setProperty('padding-top', paddingTop);
try {
localStorage.setItem('paneContentPaddingTop', paddingTop);
} catch(ex) {
}
localStorage.setItem('paneContentPaddingTop', paddingTop);
} }
document.body.classList.toggle( document.body.classList.toggle(
'hConstrained', 'hConstrained',

Loading…
Cancel
Save