go-neb

Commit Graph

Author	SHA1	Message	Date
Kegsay	89056ebf9e	Merge pull request #152 from matrix-org/kegan/matrix-org-util Use github.com/matrix-org/util	9 years ago
Kegan Dougal	3a7d5f84da	Bump requirements to Go 1.7 for net/http.Request.Context()	9 years ago
Kegan Dougal	cbc30321a4	Use github.com/matrix-org/util	9 years ago
Kegan Dougal	d6d19a8f6c	Add GH Webhook test	9 years ago
Kegsay	ae5b0df563	Merge pull request #147 from matrix-org/kegan/fix-log-field-names Do not use log field names 'level', 'msg' or 'time'	9 years ago
Kegan Dougal	356ada4add	Do not use log field names 'level', 'msg' or 'time' By default logrus uses these keys. If we also define one, logrus detects this and then works around by adding 'fields.whatever' as the key name. However, in the process of adding the key to the `Fields` it causes a race condition which can crash the process with concurrent map r/w errors.	9 years ago
Kegsay	c7a127c2d8	Implement slackapi Service (#116 )	9 years ago
Kegsay	5abfa281f5	Merge pull request #142 from matrix-org/kegan/gh-help Add "!github help" and fix command selection bug	9 years ago
Kegan Dougal	96109afd41	Add "!github help" and fix command selection bug The last command would always be chosen due to pointer fail.	9 years ago
Kegan Dougal	34ea2d06ce	Give a more helpful error message if a service is created with an unknown user ID	9 years ago
Kegsay	b1fe968f83	Merge pull request #137 from matrix-org/kegan/gomatrix Use gomatrix	9 years ago
Kegan Dougal	8d75494c19	Also log when clients are created	9 years ago
Kegan Dougal	efe04d7917	Keep doing the Inviter hack when joining rooms so non-ops can kick the bot they invited	9 years ago
Kegan Dougal	e94ab0d18e	And log when we stop	9 years ago
Kegan Dougal	9708e6351b	Stop syncing on nil errors	9 years ago
Kegan Dougal	60429f32b3	Bug fixes	9 years ago
Kegan Dougal	b98e878227	Use gomatrix	9 years ago
Kegsay	2480163739	Merge pull request #135 from matrix-org/kegan/min-guid-length Redo how recent GUIDs are calculated	9 years ago
Kegsay	9f77111702	Merge pull request #136 from matrix-org/kegan/feed-leak Don't use gofeed.ParseURL	9 years ago
Kegan Dougal	7522ddf1a4	Explain why no ParseURL	9 years ago
Kegan Dougal	c4e98238d8	uniq prior to length checks for accuracy	9 years ago
Kegan Dougal	1722871345	Don't use gofeed.ParseURL It leaks the response because it doesn't close the `resp.Body` on non-2xx.	9 years ago
Kegan Dougal	332b451d77	Redo how recent GUIDs are calculated This is an attempt to fix #133. Previously, we just clobbered the recent GUIDs with the lastest response every single time, assuming that Atom/RSS feeds would consistently return the same items. This appears to not be the case. In the wild, the number of items returned on a single request can vary (sometimes even being 1 or 2 when usually it is 50!). This patch alters how many and which GUIDs we keep between requests, in an attempt to prevent sending old news for buggy RSS feeds.	9 years ago
Kegan Dougal	d128ed2626	Add more logging for RSS feeds	9 years ago
Kegsay	357abef22c	Merge pull request #134 from matrix-org/kegan/rss-dont-replace-if-no-guids Treat RSS feeds with 0 items as errors	9 years ago
Kegan Dougal	677b556376	Return an error so it is logged	9 years ago
Kegan Dougal	66fb3253f7	Treat RSS feeds with 0 items as errors In the wild it looks like some RSS feeds will occasionally return 0 items to requests but not return an error. This previously meant we would clobber our knowledge of recent GUIDs with the empty set. This meant that the next successful poll would resend the entire RSS feed.	9 years ago
Kegsay	d7eb332948	Merge pull request #132 from matrix-org/kegan/giphy-translate-api Use Giphy's translate API for better accuracy	9 years ago
Kegan Dougal	729d004ad0	Use Giphy's translate API for better accuracy	9 years ago
Kegsay	f2383a89ac	Merge pull request #131 from matrix-org/kegan/finer-gh-controls Break apart 'issues' and 'pull_request' events	9 years ago
Kegan Dougal	aec58233d9	s/assign/assignments/	9 years ago
Kegan Dougal	4d918673c0	Break apart 'issues' and 'pull_request' events Now broken down into: - `labels` : Labelling/Unlabelling issues/PRs - `milestones` : Milestoning/Demilestoning issues/PRs - `assign` : Assigning/Unassigning issues/PRs This is broken down in the guts of parsing the webhook event such that it appears to be a unique `X-GitHub-Event` type.	9 years ago
Kegsay	402e29782a	Merge pull request #129 from matrix-org/kegan/testutils Add a dedicated testutils package	9 years ago
Kegan Dougal	683d36b5c5	Review comments	9 years ago
Kegsay	3055e2fd8d	Merge pull request #130 from matrix-org/kegan/smart-quotes Fix #72: Support smart quotes	9 years ago
Kegan Dougal	a9899557c5	Fix #72 : Support smart quotes	9 years ago
Kegan Dougal	7a382c8120	Add failing command parse tests	9 years ago
Kegan Dougal	8ec37a4cf9	Add a dedicated testutils package In the spirit of "if you have to do something 3 times then factor it out", make a testutils package to put all the `RoundTrip` boilerplate. I don't overly like having test packages, especially mixed in with code, but I don't see a nicer way of doing this without ending up with a sprawling mess of copypasta'd test boilerplate which will be an absolute nightmare to maintain. I think this is the lesser of two evils.	9 years ago
Kegsay	af32bdb4e3	Merge pull request #125 from matrix-org/kegan/github-say-which-labels Fix #105 : Mention which label was added/removed	10 years ago
Kegan Dougal	314db5f6c7	Fix #105 : Mention which label was added/removed	10 years ago
Kegsay	bde6fb10df	Merge pull request #122 from matrix-org/kegan/text-logging Use a text formatter which logs as key=val instead of JSON	10 years ago
Kegsay	16902074cf	Merge pull request #124 from matrix-org/kegan/dots-in-repos Allow '.' in owner/repo strings	10 years ago
Kegsay	aba9820844	Merge pull request #123 from matrix-org/kegan/case-insensitive-commands Fix #59 : Make pling commands case-insensitive	10 years ago
Kegan Dougal	085d3ecfd0	Allow '.' in owner/repo strings	10 years ago
Kegan Dougal	4a3431efbb	Fix #59 : Make pling commands case-insensitive	10 years ago
Kegan Dougal	14f49f2fde	Use a text formatter which logs as key=val instead of JSON We exclusively view logs using `less` and `tail`. These do not read JSON well. Logging as JSON makes it a PITA to read logs and debug problems. We do not appear to make use of JSON logging, and have no good terminal-based structured log viewer either. As a result, I've now removed JSON logging from this project and replaced it with the standard `TextFormatter` (colors off). This still logs in a structured way: ``` time="2016-11-18 16:25:46.787373" level=info msg="Got filter ID" filter=717 syncing=1 user_id="@goneb:localhost" time="2016-11-18 16:25:46.787525" level=info msg="Starting sync" next_batch="s26928_287972_2_1029_26_1_2" syncing=1 user_id="@goneb:localhost" ``` So we can still analyse logs sanely at a later date should we need to. This feels like the best compromise here between pragmatism and ideals.	10 years ago
Kegan Dougal	58df215ad6	Only emit travis results on success change	10 years ago
Kegsay	6bfcbfee18	Update README.md	10 years ago
Kegsay	ca24fb1955	Update README.md	10 years ago
Kegsay	182f0bbb6b	Add build badge	10 years ago

1 2 3 4 5 ...

432 Commits (89056ebf9e810d6e1e282007caf201ec9d1ee510) All Branches Search

432 Commits (89056ebf9e810d6e1e282007caf201ec9d1ee510)

All Branches