Browse Source

Add TODO to parse the rest of the config to make sure no webhook config was supplied

kegan/gh-service-client-id-is-opt
Kegan Dougal 8 years ago
parent
commit
0ad4fc6135
  1. 1
      src/github.com/matrix-org/go-neb/services/github/github.go

1
src/github.com/matrix-org/go-neb/services/github/github.go

@ -224,6 +224,7 @@ func (s *githubService) PostRegister(oldService types.Service) {
// PostRegister handles creating/destroying webhooks, which is only valid if this service
// is configured on behalf of a client.
if s.ClientUserID == "" {
// TODO: We should log an error here if the service has any webhook config in Rooms
return
}

Loading…
Cancel
Save