From 0ad4fc6135cc608a84a21806ca7c10ccbb43956a Mon Sep 17 00:00:00 2001 From: Kegan Dougal Date: Fri, 19 Aug 2016 17:43:04 +0100 Subject: [PATCH] Add TODO to parse the rest of the config to make sure no webhook config was supplied --- src/github.com/matrix-org/go-neb/services/github/github.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/github.com/matrix-org/go-neb/services/github/github.go b/src/github.com/matrix-org/go-neb/services/github/github.go index 4f7dffb..5a3e337 100644 --- a/src/github.com/matrix-org/go-neb/services/github/github.go +++ b/src/github.com/matrix-org/go-neb/services/github/github.go @@ -224,6 +224,7 @@ func (s *githubService) PostRegister(oldService types.Service) { // PostRegister handles creating/destroying webhooks, which is only valid if this service // is configured on behalf of a client. if s.ClientUserID == "" { + // TODO: We should log an error here if the service has any webhook config in Rooms return }