Update localcopy.sh, shellcheck'ed and shfmt'ed

deploy/localcopy.sh

@@ -42,46 +42,42 @@ localcopy_deploy() {
   if [ "$DEPLOY_LOCALCOPY_CERTIFICATE" ]; then
     _info "Copying certificate"
     _debug "Copying $_ccert to $DEPLOY_LOCALCOPY_CERTIFICATE"
-    eval "cp $_ccert $DEPLOY_LOCALCOPY_CERTIFICATE"
-    if [ $? -ne 0 ]; then
+    if ! eval "cp $_ccert $DEPLOY_LOCALCOPY_CERTIFICATE"; then
       _err "Failed to copy certificate, aborting."
-      return 1;
-    fi;
+      return 1
+    fi
     _savedeployconf DEPLOY_LOCALCOPY_CERTIFICATE "$DEPLOY_LOCALCOPY_CERTIFICATE"
-  fi;
+  fi
 
   if [ "$DEPLOY_LOCALCOPY_CERTKEY" ]; then
     _info "Copying certificate key"
     _debug "Copying $_ckey to $DEPLOY_LOCALCOPY_CERTKEY"
-    eval "cp $_ckey $DEPLOY_LOCALCOPY_CERTKEY"
-    if [ $? -ne 0 ]; then
+    if ! eval "cp $_ckey $DEPLOY_LOCALCOPY_CERTKEY"; then
       _err "Failed to copy certificate key, aborting."
-      return 1;
-    fi;
+      return 1
+    fi
     _savedeployconf DEPLOY_LOCALCOPY_CERTKEY "$DEPLOY_LOCALCOPY_CERTKEY"
-  fi;
+  fi
 
   if [ "$DEPLOY_LOCALCOPY_FULLCHAIN" ]; then
     _info "Copying fullchain"
     _debug "Copying $_cfullchain to $DEPLOY_LOCALCOPY_FULLCHAIN"
-    eval "cp $_cfullchain $DEPLOY_LOCALCOPY_FULLCHAIN"
-    if [ $? -ne 0 ]; then
+    if ! eval "cp $_cfullchain $DEPLOY_LOCALCOPY_FULLCHAIN"; then
       _err "Failed to copy fullchain, aborting."
-      return 1;
-    fi;
+      return 1
+    fi
     _savedeployconf DEPLOY_LOCALCOPY_FULLCHAIN "$DEPLOY_LOCALCOPY_FULLCHAIN"
-  fi;
+  fi
 
   if [ "$DEPLOY_LOCALCOPY_CA" ]; then
     _info "Copying CA"
     _debug "Copying $_cca to $DEPLOY_LOCALCOPY_CA"
-    eval "cp $_cca $DEPLOY_LOCALCOPY_CA"
-    if [ $? -ne 0 ]; then
+    if ! eval "cp $_cca $DEPLOY_LOCALCOPY_CA"; then
       _err "Failed to copy CA, aborting."
-      return 1;
-    fi;
+      return 1
+    fi
     _savedeployconf DEPLOY_LOCALCOPY_CA "$DEPLOY_LOCALCOPY_CA"
-  fi;
+  fi
 
   _reload=$DEPLOY_LOCALCOPY_RELOADCMD
   _debug "Running reloadcmd $_reload"
@@ -90,16 +86,15 @@ localcopy_deploy() {
     _info "Reloadcmd not provided, skipping."
   else
     _info "Reloading"
-    if eval $_reload; then
+    if eval "$_reload"; then
       _info "Reload successful."
       _savedeployconf DEPLOY_LOCALCOPY_RELOADCMD "$DEPLOY_LOCALCOPY_RELOADCMD" "base64"
     else
       _err "Reload failed."
-      return 1;
-    fi;
-  fi;
+      return 1
+    fi
+  fi
 
   _info "$(__green "'localcopy' deploy success")"
   return 0
 }
-