shell check war warning against unnecessary use of cat

3 years ago · 6d64098288
1 changed files with 2 additions and 2 deletions
--- a/deploy/proxmoxve.sh
+++ b/deploy/proxmoxve.sh
@ -93,8 +93,8 @@ proxmoxve_deploy(){
  # posted to the webserver.
  cat << HEREDOC > "$_proxmoxve_temp_data_file"
 {
-  "certificates": "$(cat "$_cfullchain"|tr '\n' ':'|sed 's/:/\\n/g')",
-  "key": "$(cat "$_ckey"|tr '\n' ':'|sed 's/:/\\n/g')",
+  "certificates": "$(tr '\n' ':' < "$_cfullchain" | sed 's/:/\\n/g')",
+  "key": "$(tr '\n' ':' < "$_ckey" |sed 's/:/\\n/g')",
  "node":"$_node_name",
  "restart":"1",
  "force":"1"