Browse Source

Fix S3 uploads (#178)

My previous change that reworked how metadata generation worked was not
correct for two reasons:

* It passed the original `io.Reader` (with no bytes remaining) to
  `GenerateMetadata`
* It did not seek back to the beginning of the temporary file after
  writing to it, causing any subsequent reads to return EOF.

This change fixes both issues and S3 uploads now work fine. We really
ought to investigate adding test coverage to our S3 backend to avoid
similar recurrences.
pull/181/head v2.1.5
mutantmonkey 6 years ago
committed by Andrei Marcu
parent
commit
50c1bdc018
  1. 12
      backends/s3/s3.go

12
backends/s3/s3.go

@ -122,7 +122,12 @@ func (b S3Backend) Put(key string, r io.Reader, expiry time.Time, deleteKey stri
return m, err return m, err
} }
m, err = helpers.GenerateMetadata(r)
_, err = tmpDst.Seek(0, 0)
if err != nil {
return m, err
}
m, err = helpers.GenerateMetadata(tmpDst)
if err != nil { if err != nil {
return return
} }
@ -131,6 +136,11 @@ func (b S3Backend) Put(key string, r io.Reader, expiry time.Time, deleteKey stri
// XXX: we may not be able to write this to AWS easily // XXX: we may not be able to write this to AWS easily
//m.ArchiveFiles, _ = helpers.ListArchiveFiles(m.Mimetype, m.Size, tmpDst) //m.ArchiveFiles, _ = helpers.ListArchiveFiles(m.Mimetype, m.Size, tmpDst)
_, err = tmpDst.Seek(0, 0)
if err != nil {
return m, err
}
uploader := s3manager.NewUploaderWithClient(b.svc) uploader := s3manager.NewUploaderWithClient(b.svc)
input := &s3manager.UploadInput{ input := &s3manager.UploadInput{
Bucket: aws.String(b.bucket), Bucket: aws.String(b.bucket),

Loading…
Cancel
Save