From b59e6ee4c381272478350389a2ac4d7b4d617a7f Mon Sep 17 00:00:00 2001
From: Andrew Shu <talklittle@gmail.com>
Date: Sat, 9 Nov 2024 21:33:00 -0800
Subject: [PATCH] ansible: ensure self-signed certificate exists before
 starting nginx

---
 ansible/playbook.yml                              | 10 +++++++++-
 ansible/roles/self_signed_ssl_cert/meta/main.yml  |  3 ---
 ansible/roles/self_signed_ssl_cert/tasks/main.yml |  2 --
 3 files changed, 9 insertions(+), 6 deletions(-)
 delete mode 100644 ansible/roles/self_signed_ssl_cert/meta/main.yml

diff --git a/ansible/playbook.yml b/ansible/playbook.yml
index 86f5dad..2f3cfc8 100644
--- a/ansible/playbook.yml
+++ b/ansible/playbook.yml
@@ -6,6 +6,15 @@
   roles:
     - common
 
+# Do some dev tasks before app_server,
+# e.g. self_signed_ssl_cert should be done before nginx
+- hosts: dev
+  become: true
+  vars_files:
+    - vars.yml
+  roles:
+    - self_signed_ssl_cert
+
 - hosts: app_server
   become: true
   vars_files:
@@ -39,7 +48,6 @@
   vars_files:
     - vars.yml
   roles:
-    - self_signed_ssl_cert
     - prometheus
     - java
     - nodejs
diff --git a/ansible/roles/self_signed_ssl_cert/meta/main.yml b/ansible/roles/self_signed_ssl_cert/meta/main.yml
deleted file mode 100644
index 8b662c9..0000000
--- a/ansible/roles/self_signed_ssl_cert/meta/main.yml
+++ /dev/null
@@ -1,3 +0,0 @@
----
-dependencies:
-  - role: nginx
diff --git a/ansible/roles/self_signed_ssl_cert/tasks/main.yml b/ansible/roles/self_signed_ssl_cert/tasks/main.yml
index de42e8d..b7fa635 100644
--- a/ansible/roles/self_signed_ssl_cert/tasks/main.yml
+++ b/ansible/roles/self_signed_ssl_cert/tasks/main.yml
@@ -20,5 +20,3 @@
     path: "{{ ssl_cert_path }}"
     privatekey_path: "{{ ssl_private_key_path }}"
     provider: selfsigned
-  notify:
-    - Reload nginx