40d9f4fa9c
add error mapping
6 months ago
8cc99ca121
fixes
6 months ago
c5628b000b
fix tests
6 months ago
f419271299
pass tests
6 months ago
a0ab227e07
fixes
6 months ago
2ad4a924be
fix tests
6 months ago
1e1806c7a1
fixes
✅ Include VersionId in multipart upload completion responses when versioning is enabled
✅ Block retention mode changes (GOVERNANCE ↔ COMPLIANCE) without bypass permissions
✅ Handle all object lock validation errors consistently with proper error codes
✅ Pass the remaining object lock tests
6 months ago
eaaef569ce
fixes
✅ Return 409 (Conflict) with InvalidBucketState for bucket-level object lock configuration operations on buckets without object lock enabled
✅ Allow increasing retention periods and overriding retention with same/later dates
✅ Only block decreasing retention periods without proper bypass permissions
✅ Handle all object lock validation errors consistently with proper error codes
6 months ago
1807f4e94d
fixes
✅ Return MalformedXML when both Days and Years are specified in the same retention configuration
✅ Return 400 (Bad Request) with InvalidRequest when object lock operations are attempted on buckets without object lock enabled
✅ Handle all object lock validation errors consistently with proper error codes
6 months ago
7203c78e4d
constants and fixes
✅ Return InvalidRetentionPeriod for invalid retention values (0 days, negative years)
✅ Return ObjectLockConfigurationNotFoundError when object lock configuration doesn't exist
✅ Handle all object lock validation errors consistently with proper error codes
6 months ago
1bc503530a
fixes
With these final fixes, the s3-tests should now:
✅ Return MalformedXML for ObjectLockEnabled: 'Disabled'
✅ Return MalformedXML when both Days and Years are specified in retention configuration
✅ Return InvalidBucketState (409 Conflict) when trying to suspend versioning on buckets with object lock enabled
✅ Handle all object lock validation errors consistently with proper error codes
6 months ago
9f88fd2ea5
fixes
With these comprehensive fixes, the s3-tests should now:
✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets
✅ Return InvalidRetentionPeriod for invalid retention periods
✅ Return MalformedXML for malformed retention configurations
✅ Include VersionId in response headers when available
✅ Return proper HTTP status codes for all error conditions
✅ Handle all object lock validation errors consistently
The workflow should now pass significantly more object lock tests, bringing SeaweedFS's S3 object lock implementation much closer to AWS S3 compatibility standards.
6 months ago
0123abe49b
address test errors
With these fixes, the s3-tests should now:
✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets
✅ Return MalformedXML for invalid retention configurations
✅ Include VersionId in response headers when available
✅ Return proper HTTP status codes (403 Forbidden for retention mode changes)
✅ Handle all object lock validation errors consistently
6 months ago
4b92f03b65
address test errors
6 months ago
1e7a3c09d4
Update s3tests.conf
6 months ago
ddb2105f00
Update s3tests.conf
6 months ago
bbcd19f6c6
Update s3tests.yml
6 months ago
fc2fcae543
Update s3tests.yml
6 months ago
4801f641f1
install s3 tests
6 months ago
770888df81
use marker
6 months ago
1dfdd3c84d
Merge branch 'master' into fix-GetObjectLockConfigurationHandler
6 months ago
b63855560a
add s3 tests for object lock and retention
6 months ago
9f8e0257b0
read entry once
6 months ago
c6a22ce43a
Fix get object lock configuration handler ( #6996 )
* fix GetObjectLockConfigurationHandler
* cache and use bucket object lock config
* subscribe to bucket configuration changes
* increase bucket config cache TTL
* refactor
* Update weed/s3api/s3api_server.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* avoid duplidated work
* rename variable
* Update s3api_object_handlers_put.go
* fix routing
* admin ui and api handler are consistent now
* use fields instead of xml
* fix test
* address comments
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/s3/retention/s3_retention_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update weed/s3api/object_lock_utils.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* change error style
* errorf
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 months ago
e53cd29eb2
errorf
6 months ago
eeeb595346
change error style
6 months ago
678f962ded
Update weed/s3api/object_lock_utils.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 months ago
a906358c59
Update test/s3/retention/s3_retention_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 months ago
12f34f965f
Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 months ago
1db149ecc2
address comments
6 months ago
59f8444a90
fix test
6 months ago
bcc7a74a25
use fields instead of xml
6 months ago
0d4eeb67be
admin ui and api handler are consistent now
6 months ago
85e34df214
fix routing
6 months ago
bb05e6cade
Update s3api_object_handlers_put.go
6 months ago
bc46214445
rename variable
6 months ago
121f6ef2c0
avoid duplidated work
6 months ago
22673fee76
Update weed/s3api/s3api_server.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
6 months ago
3fbab20b83
refactor
6 months ago
b8cbe9b6b2
increase bucket config cache TTL
6 months ago
8bb47f3c03
subscribe to bucket configuration changes
6 months ago
7bec2ef94b
cache and use bucket object lock config
6 months ago
f9cbed7ee1
fix GetObjectLockConfigurationHandler
6 months ago
69553e5ba6
convert error fromating to %w everywhere ( #6995 )
6 months ago
a524b4f485
Object locking need to persist the tags and set the headers ( #6994 )
* fix object locking read and write
No logic to include object lock metadata in HEAD/GET response headers
No logic to extract object lock metadata from PUT request headers
* add tests for object locking
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* refactor
* add unit tests
* sync versions
* Update s3_worm_integration_test.go
* fix legal hold values
* lint
* fix tests
* racing condition when enable versioning
* fix tests
* validate put object lock header
* allow check lock permissions for PUT
* default to OFF legal hold
* only set object lock headers for objects that are actually from object lock-enabled buckets
fix --- FAIL: TestAddObjectLockHeadersToResponse/Handle_entry_with_no_object_lock_metadata (0.00s)
* address comments
* fix tests
* purge
* fix
* refactoring
* address comment
* address comment
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* avoid nil
* ensure locked objects cannot be overwritten
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 months ago
89706d36dc
less logs
6 months ago
22465b8a96
unused
6 months ago
39b574f3c5
[cosi] Update sidecar ( #6993 )
6 months ago
9982f91b4c
Add more fuse tests ( #6992 )
* add more tests
* move to new package
* add github action
* Update fuse-integration.yml
* Update fuse-integration.yml
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/fuse_integration/framework.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* fix
* Update test/fuse_integration/concurrent_operations_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
6 months ago
215c5de579
minor
6 months ago
chrislu
Chris Lu
Andrei Kvapil