diff --git a/weed/storage/needle/needle_write.go b/weed/storage/needle/needle_write.go index 95854bc27..a9650b04f 100644 --- a/weed/storage/needle/needle_write.go +++ b/weed/storage/needle/needle_write.go @@ -3,12 +3,13 @@ package needle import ( "bytes" "fmt" + "math" + "github.com/seaweedfs/seaweedfs/weed/glog" "github.com/seaweedfs/seaweedfs/weed/storage/backend" . "github.com/seaweedfs/seaweedfs/weed/storage/types" "github.com/seaweedfs/seaweedfs/weed/util" "github.com/seaweedfs/seaweedfs/weed/util/buffer_pool" - "math" ) func (n *Needle) prepareWriteBuffer(version Version, writeBytes *bytes.Buffer) (Size, int64, error) { @@ -118,7 +119,7 @@ func (n *Needle) Append(w backend.BackendStorageFile, version Version) (offset u }(w, end) offset = uint64(end) } else { - err = fmt.Errorf("Cannot Read Current Volume Position: %v", e) + err = fmt.Errorf("Cannot Read Current Volume Position: %w", e) return } if offset >= MaxPossibleVolumeSize && len(n.Data) != 0 { @@ -134,7 +135,7 @@ func (n *Needle) Append(w backend.BackendStorageFile, version Version) (offset u if err == nil { _, err = w.WriteAt(bytesBuffer.Bytes(), int64(offset)) if err != nil { - err = fmt.Errorf("failed to write %d bytes to %s at offset %d: %v", actualSize, w.Name(), offset, err) + err = fmt.Errorf("failed to write %d bytes to %s at offset %d: %w", actualSize, w.Name(), offset, err) } } diff --git a/weed/storage/store.go b/weed/storage/store.go index 3b2869a2e..2b244cf70 100644 --- a/weed/storage/store.go +++ b/weed/storage/store.go @@ -269,19 +269,23 @@ func (s *Store) CollectHeartbeat() *master_pb.Heartbeat { maxFileKey = curMaxFileKey } shouldDeleteVolume := false - if !v.expired(volumeMessage.Size, s.GetVolumeSizeLimit()) { - volumeMessages = append(volumeMessages, volumeMessage) + + if v.lastIoError != nil { + deleteVids = append(deleteVids, v.Id) + shouldDeleteVolume = true + glog.Warningf("volume %d has IO error: %v", v.Id, v.lastIoError) } else { - if v.expiredLongEnough(MAX_TTL_VOLUME_REMOVAL_DELAY) { - deleteVids = append(deleteVids, v.Id) - shouldDeleteVolume = true + if !v.expired(volumeMessage.Size, s.GetVolumeSizeLimit()) { + volumeMessages = append(volumeMessages, volumeMessage) } else { - glog.V(0).Infof("volume %d is expired", v.Id) - } - if v.lastIoError != nil { - deleteVids = append(deleteVids, v.Id) - shouldDeleteVolume = true - glog.Warningf("volume %d has IO error: %v", v.Id, v.lastIoError) + if v.expiredLongEnough(MAX_TTL_VOLUME_REMOVAL_DELAY) { + if !shouldDeleteVolume { + deleteVids = append(deleteVids, v.Id) + shouldDeleteVolume = true + } + } else { + glog.V(0).Infof("volume %d is expired", v.Id) + } } } diff --git a/weed/storage/volume_write.go b/weed/storage/volume_write.go index cf959b576..200ee9c14 100644 --- a/weed/storage/volume_write.go +++ b/weed/storage/volume_write.go @@ -5,6 +5,7 @@ import ( "errors" "fmt" "os" + "syscall" "github.com/seaweedfs/seaweedfs/weed/glog" "github.com/seaweedfs/seaweedfs/weed/storage/backend" @@ -23,7 +24,7 @@ func (v *Volume) checkReadWriteError(err error) { } return } - if err.Error() == "input/output error" { + if errors.Is(err, syscall.EIO) { v.lastIoError = err } }