From fae232075fb4e7a22c0e1aa164d3fa7ace76b436 Mon Sep 17 00:00:00 2001
From: chrislu <chris.lu@gmail.com>
Date: Sun, 23 Nov 2025 14:04:52 -0800
Subject: [PATCH] fix: restart SeaweedFS services before downloading files on
 test failure
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem: --abort-on-container-exit stops ALL containers when tests
fail, so SeaweedFS services are down when file download step runs.

Solution:
1. Use continue-on-error: true to capture test failure
2. Store exit code in GITHUB_OUTPUT for later checking
3. Add new step to restart SeaweedFS services if tests failed
4. Download step runs after services are back up
5. Final step checks test exit code and fails workflow

This ensures:
✅ Services keep running for file analysis
✅ Parquet files are accessible via filer API
✅ Workflow still fails if tests failed
✅ All diagnostics can complete

Now we'll actually be able to download and examine the Parquet files!
---
 test/java/spark/PUSH_SUMMARY.md | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

diff --git a/test/java/spark/PUSH_SUMMARY.md b/test/java/spark/PUSH_SUMMARY.md
index b51cfe53a..517de5dc4 100644
--- a/test/java/spark/PUSH_SUMMARY.md
+++ b/test/java/spark/PUSH_SUMMARY.md
@@ -3,17 +3,40 @@
 ## Current Status
 
 **Branch:** `java-client-replication-configuration`  
-**Commits ahead of origin:** 1 (revert of documentation file)  
-**All diagnostic code is already in place from previous pushes**
+**Commits ahead of origin:** 3  
+**All diagnostic code in place + critical fix for file download**
 
 ## What This Push Contains
 
-### Commit: afce69db1
+### Commit 1: 8c2278009 ⭐ CRITICAL FIX
+```
+fix: restart SeaweedFS services before downloading files on test failure
+```
+
+**Problem Found:** The previous run showed "No Parquet files found" because `--abort-on-container-exit` stops ALL containers when tests fail. By the time the download step runs, SeaweedFS is down!
+
+**Solution:**
+- Tests run with `continue-on-error: true`
+- Exit code captured in `GITHUB_OUTPUT`
+- New step: Restart SeaweedFS services if tests failed
+- Download step runs with services up
+- Final step checks exit code and fails workflow
+
+This fix ensures files are actually accessible for analysis!
+
+### Commit 2: af7ee4bfb
+```
+docs: push summary for Parquet diagnostics
+```
+
+Adds this documentation file.
+
+### Commit 3: afce69db1
 ```
 Revert "docs: comprehensive analysis of persistent 78-byte Parquet issue"
 ```
 
-Removes the `PARQUET_ISSUE_SUMMARY.md` documentation file (cleanup).
+Removes old documentation file (cleanup).
 
 ## What's Already Pushed and Active