From f5a57a6463428a7c07179ff445a7853112bee6a0 Mon Sep 17 00:00:00 2001 From: chrislu Date: Thu, 30 Oct 2025 09:11:30 -0700 Subject: [PATCH] fixed superfluous response.WriteHeader call" warning --- weed/server/common.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/weed/server/common.go b/weed/server/common.go index 49dd78ce0..930695f4b 100644 --- a/weed/server/common.go +++ b/weed/server/common.go @@ -369,8 +369,7 @@ func ProcessRangeRequest(r *http.Request, w http.ResponseWriter, totalSize int64 err = writeFn(bufferedWriter) if err != nil { glog.Errorf("ProcessRangeRequest range[0]: %+v err: %v", w.Header(), err) - w.Header().Del("Content-Length") - http.Error(w, err.Error(), http.StatusInternalServerError) + // Cannot call http.Error() here because WriteHeader was already called return fmt.Errorf("ProcessRangeRequest range[0]: %w", err) } return nil @@ -424,7 +423,7 @@ func ProcessRangeRequest(r *http.Request, w http.ResponseWriter, totalSize int64 w.WriteHeader(http.StatusPartialContent) if _, err := io.CopyN(bufferedWriter, sendContent, sendSize); err != nil { glog.Errorf("ProcessRangeRequest err: %v", err) - http.Error(w, "Internal Error", http.StatusInternalServerError) + // Cannot call http.Error() here because WriteHeader was already called return fmt.Errorf("ProcessRangeRequest err: %w", err) } return nil