From f4f2718ba05b13c51f14a316c48a256da6a77fe8 Mon Sep 17 00:00:00 2001 From: chrislu Date: Mon, 3 Nov 2025 16:22:20 -0800 Subject: [PATCH] adjust test --- .../s3_bucket_delete_with_lock_test.go | 24 +++++++++++++------ 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/test/s3/retention/s3_bucket_delete_with_lock_test.go b/test/s3/retention/s3_bucket_delete_with_lock_test.go index 3a91f0369..271855f31 100644 --- a/test/s3/retention/s3_bucket_delete_with_lock_test.go +++ b/test/s3/retention/s3_bucket_delete_with_lock_test.go @@ -27,22 +27,32 @@ func TestBucketDeletionWithObjectLock(t *testing.T) { retentionTestCases := []struct { name string lockMode types.ObjectLockMode + key string + content string }{ - {name: "ComplianceRetention", lockMode: types.ObjectLockModeCompliance}, - {name: "GovernanceRetention", lockMode: types.ObjectLockModeGovernance}, + { + name: "ComplianceRetention", + lockMode: types.ObjectLockModeCompliance, + key: "test-compliance-retention", + content: "test content for compliance retention", + }, + { + name: "GovernanceRetention", + lockMode: types.ObjectLockModeGovernance, + key: "test-governance-retention", + content: "test content for governance retention", + }, } for _, tc := range retentionTestCases { t.Run(fmt.Sprintf("CannotDeleteBucketWith%s", tc.name), func(t *testing.T) { - key := fmt.Sprintf("test-%s", strings.ToLower(strings.ReplaceAll(tc.name, "Retention", "-retention"))) - content := fmt.Sprintf("test content for %s", strings.ToLower(tc.name)) retainUntilDate := time.Now().Add(10 * time.Second) // 10 seconds in future // Upload object with retention _, err := client.PutObject(context.Background(), &s3.PutObjectInput{ Bucket: aws.String(bucketName), - Key: aws.String(key), - Body: strings.NewReader(content), + Key: aws.String(tc.key), + Body: strings.NewReader(tc.content), ObjectLockMode: tc.lockMode, ObjectLockRetainUntilDate: aws.Time(retainUntilDate), }) @@ -63,7 +73,7 @@ func TestBucketDeletionWithObjectLock(t *testing.T) { // Delete the object _, err = client.DeleteObject(context.Background(), &s3.DeleteObjectInput{ Bucket: aws.String(bucketName), - Key: aws.String(key), + Key: aws.String(tc.key), }) require.NoError(t, err, "DeleteObject should succeed after retention expires")