From f0eb4dc8cb89ec5945987da47aa7892c27d9bdb9 Mon Sep 17 00:00:00 2001 From: chrislu Date: Thu, 4 Dec 2025 14:05:05 -0800 Subject: [PATCH] test: handle crc32 Write error return for completeness --- weed/s3api/chunked_reader_v4_test.go | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/weed/s3api/chunked_reader_v4_test.go b/weed/s3api/chunked_reader_v4_test.go index e2b5af2e5..b75a9aa86 100644 --- a/weed/s3api/chunked_reader_v4_test.go +++ b/weed/s3api/chunked_reader_v4_test.go @@ -286,9 +286,10 @@ func TestSignedStreamingUploadWithTrailer(t *testing.T) { finalSignature := getSignature(signingKey, finalStringToSign) // Calculate CRC32 checksum for trailer - writer := crc32.NewIEEE() - writer.Write([]byte(chunk1Data)) - checksum := writer.Sum(nil) + crcWriter := crc32.NewIEEE() + _, crcErr := crcWriter.Write([]byte(chunk1Data)) + assert.NoError(t, crcErr) + checksum := crcWriter.Sum(nil) base64EncodedChecksum := base64.StdEncoding.EncodeToString(checksum) // Calculate trailer signature @@ -387,9 +388,10 @@ func TestSignedStreamingUploadWithTrailerInvalidSignature(t *testing.T) { finalSignature := getSignature(signingKey, finalStringToSign) // Calculate CRC32 checksum for trailer - writer := crc32.NewIEEE() - writer.Write([]byte(chunk1Data)) - checksum := writer.Sum(nil) + crcWriter := crc32.NewIEEE() + _, crcErr := crcWriter.Write([]byte(chunk1Data)) + assert.NoError(t, crcErr) + checksum := crcWriter.Sum(nil) base64EncodedChecksum := base64.StdEncoding.EncodeToString(checksum) // The on-wire trailer format uses \r\n (HTTP/aws-chunked convention)