fix has changes false if deleted result size eq zero (#4909)

* fix has changes false if deleted result size eq zero
https://github.com/seaweedfs/seaweedfs/issues/4171

* fix change respos status 202 to 304 if the file has already been deleted
https://github.com/seaweedfs/seaweedfs/issues/4171

* fix delete if set apply changes
https://github.com/seaweedfs/seaweedfs/issues/4171

---------

Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co>

weed/server/volume_grpc_batch_delete.go

@@ -87,6 +87,11 @@ func (vs *VolumeServer) BatchDelete(ctx context.Context, req *volume_server_pb.B
 					Status: http.StatusInternalServerError,
 					Error:  err.Error()},
 				)
+			} else if size == 0 {
+				resp.Results = append(resp.Results, &volume_server_pb.DeleteResult{
+					FileId: fid,
+					Status: http.StatusNotModified},
+				)
 			} else {
 				resp.Results = append(resp.Results, &volume_server_pb.DeleteResult{
 					FileId: fid,

weed/shell/command_volume_check_disk.go

@@ -271,7 +271,7 @@ func doVolumeCheckDisk(minuend, subtrahend *needle_map.MemDb, source, target *Vo
 
 	}
 
-	if doSyncDeletions && len(partiallyDeletedNeedles) > 0 {
+	if doSyncDeletions && applyChanges && len(partiallyDeletedNeedles) > 0 {
 		var fidList []string
 		for _, needleValue := range partiallyDeletedNeedles {
 			fidList = append(fidList, needleValue.Key.FileId(source.info.Id))
@@ -286,7 +286,7 @@ func doVolumeCheckDisk(minuend, subtrahend *needle_map.MemDb, source, target *Vo
 			return hasChanges, deleteErr
 		}
 		for _, deleteResult := range deleteResults {
-			if deleteResult.Status == http.StatusAccepted {
+			if deleteResult.Status == http.StatusAccepted && deleteResult.Size > 0 {
 				hasChanges = true
 				return
 			}