Browse Source

refactoring

pull/1298/head
Chris Lu 5 years ago
parent
commit
ed3cf811f5
  1. 2
      weed/filesys/meta_cache/meta_cache.go
  2. 2
      weed/filesys/wfs.go
  3. 6
      weed/messaging/broker/broker_append.go
  4. 2
      weed/messaging/client/subscriber.go
  5. 2
      weed/replication/sink/filersink/fetch_write.go
  6. 10
      weed/replication/source/filer_source.go
  7. 2
      weed/s3api/s3api_handlers.go
  8. 2
      weed/server/webdav_server.go
  9. 1
      weed/shell/command_fs_lock_unlock.go
  10. 2
      weed/shell/command_fs_meta_save.go
  11. 2
      weed/shell/commands.go

2
weed/filesys/meta_cache/meta_cache.go

@ -34,4 +34,4 @@ func openMetaStore(dbFolder string) filer2.FilerStore {
return store
}
}

2
weed/filesys/wfs.go

@ -117,6 +117,8 @@ func (wfs *WFS) Root() (fs.Node, error) {
return wfs.root, nil
}
var _ = filer_pb.FilerClient(&WFS{})
func (wfs *WFS) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
err := pb.WithCachedGrpcClient(func(grpcConnection *grpc.ClientConn) error {

6
weed/messaging/broker/broker_append.go

@ -98,6 +98,8 @@ func (broker *MessageBroker) assignAndUpload(topicConfig *messaging_pb.TopicConf
return assignResult, uploadResult, nil
}
var _ = filer_pb.FilerClient(&MessageBroker{})
func (broker *MessageBroker) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) (err error) {
for _, filer := range broker.option.Filers {
@ -111,3 +113,7 @@ func (broker *MessageBroker) WithFilerClient(fn func(filer_pb.SeaweedFilerClient
return
}
func (broker *MessageBroker) AdjustedUrl(hostAndPort string) string {
return hostAndPort
}

2
weed/messaging/client/subscriber.go

@ -85,7 +85,7 @@ func (s *Subscriber) doSubscribe(partition int, processFn func(m *messaging_pb.M
// Subscribe starts goroutines to process the messages
func (s *Subscriber) Subscribe(processFn func(m *messaging_pb.Message)) {
for i:=0;i<len(s.subscriberClients);i++{
for i := 0; i < len(s.subscriberClients); i++ {
go s.doSubscribe(i, processFn)
}
}

2
weed/replication/sink/filersink/fetch_write.go

@ -113,6 +113,8 @@ func (fs *FilerSink) fetchAndWrite(sourceChunk *filer_pb.FileChunk, dir string)
return
}
var _ = filer_pb.FilerClient(&FilerSink{})
func (fs *FilerSink) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
return pb.WithCachedGrpcClient(func(grpcConnection *grpc.ClientConn) error {

10
weed/replication/source/filer_source.go

@ -47,7 +47,7 @@ func (fs *FilerSource) LookupFileId(part string) (fileUrl string, err error) {
vid := volumeId(part)
err = fs.withFilerClient(func(client filer_pb.SeaweedFilerClient) error {
err = fs.WithFilerClient(func(client filer_pb.SeaweedFilerClient) error {
glog.V(4).Infof("read lookup volume id locations: %v", vid)
resp, err := client.LookupVolume(context.Background(), &filer_pb.LookupVolumeRequest{
@ -91,7 +91,9 @@ func (fs *FilerSource) ReadPart(part string) (filename string, header http.Heade
return filename, header, readCloser, err
}
func (fs *FilerSource) withFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
var _ = filer_pb.FilerClient(&FilerSource{})
func (fs *FilerSource) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
return pb.WithCachedGrpcClient(func(grpcConnection *grpc.ClientConn) error {
client := filer_pb.NewSeaweedFilerClient(grpcConnection)
@ -100,6 +102,10 @@ func (fs *FilerSource) withFilerClient(fn func(filer_pb.SeaweedFilerClient) erro
}
func (fs *FilerSource) AdjustedUrl(hostAndPort string) string {
return hostAndPort
}
func volumeId(fileId string) string {
lastCommaIndex := strings.LastIndex(fileId, ",")
if lastCommaIndex > 0 {

2
weed/s3api/s3api_handlers.go

@ -38,6 +38,8 @@ func encodeResponse(response interface{}) []byte {
return bytesBuffer.Bytes()
}
var _ = filer_pb.FilerClient(&S3ApiServer{})
func (s3a *S3ApiServer) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
return pb.WithCachedGrpcClient(func(grpcConnection *grpc.ClientConn) error {

2
weed/server/webdav_server.go

@ -110,6 +110,8 @@ func NewWebDavFileSystem(option *WebDavOption) (webdav.FileSystem, error) {
}, nil
}
var _ = filer_pb.FilerClient(&WebDavFileSystem{})
func (fs *WebDavFileSystem) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
return pb.WithCachedGrpcClient(func(grpcConnection *grpc.ClientConn) error {

1
weed/shell/command_fs_lock_unlock.go

@ -52,4 +52,3 @@ func (c *commandUnlock) Do(args []string, commandEnv *CommandEnv, writer io.Writ
return nil
}

2
weed/shell/command_fs_meta_save.go

@ -140,4 +140,4 @@ func doTraverseBfsAndSaving(filerClient filer_pb.FilerClient, writer io.Writer,
fmt.Fprintf(writer, "total %d directories, %d files\n", dirCount, fileCount)
}
return err
}
}

2
weed/shell/commands.go

@ -92,6 +92,8 @@ func (ce *CommandEnv) checkDirectory(path string) error {
}
var _ = filer_pb.FilerClient(&CommandEnv{})
func (ce *CommandEnv) WithFilerClient(fn func(filer_pb.SeaweedFilerClient) error) error {
filerGrpcAddress := fmt.Sprintf("%s:%d", ce.option.FilerHost, ce.option.FilerPort+10000)

Loading…
Cancel
Save