refactor

weed/shell/command.go

@@ -6,9 +6,15 @@ type command interface {
 	Name() string
 	Help() string
 	Do([]string, *CommandEnv, io.Writer) error
-	IsResourceHeavy() bool
+	HasTag(tag CommandTag) bool
 }
 
 var (
 	Commands = []command{}
 )
+
+type CommandTag string
+
+const (
+	ResourceHeavy CommandTag = "resourceHeavy"
+)

weed/shell/command_cluster_check.go

@@ -32,7 +32,7 @@ func (c *commandClusterCheck) Help() string {
 `
 }
 
-func (c *commandClusterCheck) IsResourceHeavy() bool {
+func (c *commandClusterCheck) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_cluster_ps.go

@@ -35,7 +35,7 @@ func (c *commandClusterPs) Help() string {
 `
 }
 
-func (c *commandClusterPs) IsResourceHeavy() bool {
+func (c *commandClusterPs) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_cluster_raft_add.go

@@ -27,7 +27,7 @@ func (c *commandRaftServerAdd) Help() string {
 `
 }
 
-func (c *commandRaftServerAdd) IsResourceHeavy() bool {
+func (c *commandRaftServerAdd) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_cluster_raft_ps.go

@@ -26,7 +26,7 @@ func (c *commandRaftClusterPs) Help() string {
 `
 }
 
-func (c *commandRaftClusterPs) IsResourceHeavy() bool {
+func (c *commandRaftClusterPs) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_cluster_raft_remove.go

@@ -27,7 +27,7 @@ func (c *commandRaftServerRemove) Help() string {
 `
 }
 
-func (c *commandRaftServerRemove) IsResourceHeavy() bool {
+func (c *commandRaftServerRemove) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_collection_delete.go

@@ -28,7 +28,7 @@ func (c *commandCollectionDelete) Help() string {
 `
 }
 
-func (c *commandCollectionDelete) IsResourceHeavy() bool {
+func (c *commandCollectionDelete) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_collection_list.go

@@ -23,7 +23,7 @@ func (c *commandCollectionList) Help() string {
 	return `list all collections`
 }
 
-func (c *commandCollectionList) IsResourceHeavy() bool {
+func (c *commandCollectionList) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_ec_balance.go

@@ -98,7 +98,7 @@ func (c *commandEcBalance) Help() string {
 `
 }
 
-func (c *commandEcBalance) IsResourceHeavy() bool {
+func (c *commandEcBalance) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_ec_decode.go

@@ -37,7 +37,7 @@ func (c *commandEcDecode) Help() string {
 `
 }
 
-func (c *commandEcDecode) IsResourceHeavy() bool {
+func (c *commandEcDecode) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_ec_encode.go

@@ -56,7 +56,7 @@ func (c *commandEcEncode) Help() string {
 `
 }
 
-func (c *commandEcEncode) IsResourceHeavy() bool {
+func (c *commandEcEncode) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_ec_rebuild.go

@@ -55,7 +55,7 @@ func (c *commandEcRebuild) Help() string {
 `
 }
 
-func (c *commandEcRebuild) IsResourceHeavy() bool {
+func (c *commandEcRebuild) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_cat.go

@@ -26,7 +26,7 @@ func (c *commandFsCat) Help() string {
 `
 }
 
-func (c *commandFsCat) IsResourceHeavy() bool {
+func (c *commandFsCat) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_cd.go

@@ -28,7 +28,7 @@ func (c *commandFsCd) Help() string {
 `
 }
 
-func (c *commandFsCd) IsResourceHeavy() bool {
+func (c *commandFsCd) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_configure.go

@@ -46,7 +46,7 @@ func (c *commandFsConfigure) Help() string {
 `
 }
 
-func (c *commandFsConfigure) IsResourceHeavy() bool {
+func (c *commandFsConfigure) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_du.go

@@ -29,7 +29,7 @@ func (c *commandFsDu) Help() string {
 `
 }
 
-func (c *commandFsDu) IsResourceHeavy() bool {
+func (c *commandFsDu) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_log.go

@@ -27,7 +27,7 @@ func (c *commandFsLogPurge) Help() string {
 `
 }
 
-func (c *commandFsLogPurge) IsResourceHeavy() bool {
+func (c *commandFsLogPurge) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_ls.go

@@ -33,7 +33,7 @@ func (c *commandFsLs) Help() string {
 `
 }
 
-func (c *commandFsLs) IsResourceHeavy() bool {
+func (c *commandFsLs) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_merge_volumes.go

@@ -44,7 +44,7 @@ func (c *commandFsMergeVolumes) Help() string {
 `
 }
 
-func (c *commandFsMergeVolumes) IsResourceHeavy() bool {
+func (c *commandFsMergeVolumes) HasTag(CommandTag) bool {
 	return false
 }
 
@@ -326,7 +326,7 @@ func moveChunk(chunk *filer_pb.FileChunk, toVolumeId needle.VolumeId, masterClie
 	if err != nil {
 		return err
 	}
-	
+
 	_, err, _ = uploader.Upload(reader, &operation.UploadOption{
 		UploadUrl:         uploadURL,
 		Filename:          filename,

weed/shell/command_fs_meta_cat.go

@@ -30,7 +30,7 @@ func (c *commandFsMetaCat) Help() string {
 `
 }
 
-func (c *commandFsMetaCat) IsResourceHeavy() bool {
+func (c *commandFsMetaCat) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_meta_change_volume_id.go

@@ -37,7 +37,7 @@ func (c *commandFsMetaChangeVolumeId) Help() string {
 `
 }
 
-func (c *commandFsMetaChangeVolumeId) IsResourceHeavy() bool {
+func (c *commandFsMetaChangeVolumeId) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_meta_load.go

@@ -38,7 +38,7 @@ func (c *commandFsMetaLoad) Help() string {
 `
 }
 
-func (c *commandFsMetaLoad) IsResourceHeavy() bool {
+func (c *commandFsMetaLoad) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_meta_notify.go

@@ -30,7 +30,7 @@ func (c *commandFsMetaNotify) Help() string {
 `
 }
 
-func (c *commandFsMetaNotify) IsResourceHeavy() bool {
+func (c *commandFsMetaNotify) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_meta_save.go

@@ -44,7 +44,7 @@ func (c *commandFsMetaSave) Help() string {
 `
 }
 
-func (c *commandFsMetaSave) IsResourceHeavy() bool {
+func (c *commandFsMetaSave) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_mkdir.go

@@ -27,7 +27,7 @@ func (c *commandFsMkdir) Help() string {
 `
 }
 
-func (c *commandFsMkdir) IsResourceHeavy() bool {
+func (c *commandFsMkdir) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_mv.go

@@ -34,7 +34,7 @@ func (c *commandFsMv) Help() string {
 `
 }
 
-func (c *commandFsMv) IsResourceHeavy() bool {
+func (c *commandFsMv) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_pwd.go

@@ -20,7 +20,7 @@ func (c *commandFsPwd) Help() string {
 	return `print out current directory`
 }
 
-func (c *commandFsPwd) IsResourceHeavy() bool {
+func (c *commandFsPwd) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_rm.go

@@ -34,7 +34,7 @@ func (c *commandFsRm) Help() string {
 `
 }
 
-func (c *commandFsRm) IsResourceHeavy() bool {
+func (c *commandFsRm) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_tree.go

@@ -28,7 +28,7 @@ func (c *commandFsTree) Help() string {
 `
 }
 
-func (c *commandFsTree) IsResourceHeavy() bool {
+func (c *commandFsTree) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_fs_verify.go

@@ -51,7 +51,7 @@ func (c *commandFsVerify) Help() string {
 `
 }
 
-func (c *commandFsVerify) IsResourceHeavy() bool {
+func (c *commandFsVerify) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_lock_unlock.go

@@ -25,7 +25,7 @@ func (c *commandLock) Help() string {
 `
 }
 
-func (c *commandLock) IsResourceHeavy() bool {
+func (c *commandLock) HasTag(CommandTag) bool {
 	return false
 }
 
@@ -51,7 +51,7 @@ func (c *commandUnlock) Help() string {
 `
 }
 
-func (c *commandUnlock) IsResourceHeavy() bool {
+func (c *commandUnlock) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_mount_configure.go

@@ -34,7 +34,7 @@ func (c *commandMountConfigure) Help() string {
 `
 }
 
-func (c *commandMountConfigure) IsResourceHeavy() bool {
+func (c *commandMountConfigure) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_mq_balance.go

@@ -25,7 +25,7 @@ func (c *commandMqBalanceTopics) Help() string {
 `
 }
 
-func (c *commandMqBalanceTopics) IsResourceHeavy() bool {
+func (c *commandMqBalanceTopics) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_mq_topic_configure.go

@@ -29,7 +29,7 @@ func (c *commandMqTopicConfigure) Help() string {
 `
 }
 
-func (c *commandMqTopicConfigure) IsResourceHeavy() bool {
+func (c *commandMqTopicConfigure) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_mq_topic_desc.go

@@ -24,7 +24,7 @@ func (c *commandMqTopicDescribe) Help() string {
 	return `describe a topic`
 }
 
-func (c *commandMqTopicDescribe) IsResourceHeavy() bool {
+func (c *commandMqTopicDescribe) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_mq_topic_list.go

@@ -25,7 +25,7 @@ func (c *commandMqTopicList) Help() string {
 	return `print out all topics`
 }
 
-func (c *commandMqTopicList) IsResourceHeavy() bool {
+func (c *commandMqTopicList) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_cache.go

@@ -46,7 +46,7 @@ func (c *commandRemoteCache) Help() string {
 `
 }
 
-func (c *commandRemoteCache) IsResourceHeavy() bool {
+func (c *commandRemoteCache) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_configure.go

@@ -48,7 +48,7 @@ func (c *commandRemoteConfigure) Help() string {
 `
 }
 
-func (c *commandRemoteConfigure) IsResourceHeavy() bool {
+func (c *commandRemoteConfigure) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_meta_sync.go

@@ -44,7 +44,7 @@ func (c *commandRemoteMetaSync) Help() string {
 `
 }
 
-func (c *commandRemoteMetaSync) IsResourceHeavy() bool {
+func (c *commandRemoteMetaSync) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_mount.go

@@ -44,7 +44,7 @@ func (c *commandRemoteMount) Help() string {
 `
 }
 
-func (c *commandRemoteMount) IsResourceHeavy() bool {
+func (c *commandRemoteMount) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_mount_buckets.go

@@ -38,7 +38,7 @@ func (c *commandRemoteMountBuckets) Help() string {
 `
 }
 
-func (c *commandRemoteMountBuckets) IsResourceHeavy() bool {
+func (c *commandRemoteMountBuckets) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_uncache.go

@@ -41,7 +41,7 @@ func (c *commandRemoteUncache) Help() string {
 `
 }
 
-func (c *commandRemoteUncache) IsResourceHeavy() bool {
+func (c *commandRemoteUncache) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_remote_unmount.go

@@ -37,7 +37,7 @@ func (c *commandRemoteUnmount) Help() string {
 `
 }
 
-func (c *commandRemoteUnmount) IsResourceHeavy() bool {
+func (c *commandRemoteUnmount) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_bucket_create.go

@@ -30,7 +30,7 @@ func (c *commandS3BucketCreate) Help() string {
 `
 }
 
-func (c *commandS3BucketCreate) IsResourceHeavy() bool {
+func (c *commandS3BucketCreate) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_bucket_delete.go

@@ -28,7 +28,7 @@ func (c *commandS3BucketDelete) Help() string {
 `
 }
 
-func (c *commandS3BucketDelete) IsResourceHeavy() bool {
+func (c *commandS3BucketDelete) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_bucket_list.go

@@ -27,7 +27,7 @@ func (c *commandS3BucketList) Help() string {
 `
 }
 
-func (c *commandS3BucketList) IsResourceHeavy() bool {
+func (c *commandS3BucketList) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_bucket_quota.go

@@ -28,7 +28,7 @@ func (c *commandS3BucketQuota) Help() string {
 `
 }
 
-func (c *commandS3BucketQuota) IsResourceHeavy() bool {
+func (c *commandS3BucketQuota) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_bucket_quota_check.go

@@ -29,7 +29,7 @@ func (c *commandS3BucketQuotaEnforce) Help() string {
 `
 }
 
-func (c *commandS3BucketQuotaEnforce) IsResourceHeavy() bool {
+func (c *commandS3BucketQuotaEnforce) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_circuitbreaker.go

@@ -51,7 +51,7 @@ func (c *commandS3CircuitBreaker) Help() string {
 	`
 }
 
-func (c *commandS3CircuitBreaker) IsResourceHeavy() bool {
+func (c *commandS3CircuitBreaker) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_clean_uploads.go

@@ -34,7 +34,7 @@ func (c *commandS3CleanUploads) Help() string {
 `
 }
 
-func (c *commandS3CleanUploads) IsResourceHeavy() bool {
+func (c *commandS3CleanUploads) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_s3_configure.go

@@ -33,7 +33,7 @@ func (c *commandS3Configure) Help() string {
 	`
 }
 
-func (c *commandS3Configure) IsResourceHeavy() bool {
+func (c *commandS3Configure) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_balance.go

@@ -64,7 +64,7 @@ func (c *commandVolumeBalance) Help() string {
 `
 }
 
-func (c *commandVolumeBalance) IsResourceHeavy() bool {
+func (c *commandVolumeBalance) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_check_disk.go

@@ -48,7 +48,7 @@ func (c *commandVolumeCheckDisk) Help() string {
 `
 }
 
-func (c *commandVolumeCheckDisk) IsResourceHeavy() bool {
+func (c *commandVolumeCheckDisk) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_configure_replication.go

@@ -35,7 +35,7 @@ func (c *commandVolumeConfigureReplication) Help() string {
 `
 }
 
-func (c *commandVolumeConfigureReplication) IsResourceHeavy() bool {
+func (c *commandVolumeConfigureReplication) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_copy.go

@@ -31,7 +31,7 @@ func (c *commandVolumeCopy) Help() string {
 `
 }
 
-func (c *commandVolumeCopy) IsResourceHeavy() bool {
+func (c *commandVolumeCopy) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_delete.go

@@ -29,7 +29,7 @@ func (c *commandVolumeDelete) Help() string {
 `
 }
 
-func (c *commandVolumeDelete) IsResourceHeavy() bool {
+func (c *commandVolumeDelete) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_delete_empty.go

@@ -32,7 +32,7 @@ func (c *commandVolumeDeleteEmpty) Help() string {
 `
 }
 
-func (c *commandVolumeDeleteEmpty) IsResourceHeavy() bool {
+func (c *commandVolumeDeleteEmpty) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_fix_replication.go

@@ -55,7 +55,7 @@ func (c *commandVolumeFixReplication) Help() string {
 `
 }
 
-func (c *commandVolumeFixReplication) IsResourceHeavy() bool {
+func (c *commandVolumeFixReplication) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_fsck.go

@@ -79,7 +79,7 @@ func (c *commandVolumeFsck) Help() string {
 `
 }
 
-func (c *commandVolumeFsck) IsResourceHeavy() bool {
+func (c *commandVolumeFsck) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_grow.go

@@ -30,7 +30,7 @@ func (c *commandGrow) Help() string {
 `
 }
 
-func (c *commandGrow) IsResourceHeavy() bool {
+func (c *commandGrow) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_list.go

@@ -39,7 +39,7 @@ func (c *commandVolumeList) Help() string {
 `
 }
 
-func (c *commandVolumeList) IsResourceHeavy() bool {
+func (c *commandVolumeList) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_mark.go

@@ -28,7 +28,7 @@ func (c *commandVolumeMark) Help() string {
 `
 }
 
-func (c *commandVolumeMark) IsResourceHeavy() bool {
+func (c *commandVolumeMark) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_mount.go

@@ -33,7 +33,7 @@ func (c *commandVolumeMount) Help() string {
 `
 }
 
-func (c *commandVolumeMount) IsResourceHeavy() bool {
+func (c *commandVolumeMount) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_move.go

@@ -49,7 +49,7 @@ func (c *commandVolumeMove) Help() string {
 `
 }
 
-func (c *commandVolumeMove) IsResourceHeavy() bool {
+func (c *commandVolumeMove) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_server_evacuate.go

@@ -46,7 +46,7 @@ func (c *commandVolumeServerEvacuate) Help() string {
 `
 }
 
-func (c *commandVolumeServerEvacuate) IsResourceHeavy() bool {
+func (c *commandVolumeServerEvacuate) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_server_leave.go

@@ -35,7 +35,7 @@ func (c *commandVolumeServerLeave) Help() string {
 `
 }
 
-func (c *commandVolumeServerLeave) IsResourceHeavy() bool {
+func (c *commandVolumeServerLeave) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_tier_download.go

@@ -41,7 +41,7 @@ func (c *commandVolumeTierDownload) Help() string {
 `
 }
 
-func (c *commandVolumeTierDownload) IsResourceHeavy() bool {
+func (c *commandVolumeTierDownload) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_tier_move.go

@@ -53,7 +53,7 @@ func (c *commandVolumeTierMove) Help() string {
 `
 }
 
-func (c *commandVolumeTierMove) IsResourceHeavy() bool {
+func (c *commandVolumeTierMove) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_tier_upload.go

@@ -56,7 +56,7 @@ func (c *commandVolumeTierUpload) Help() string {
 `
 }
 
-func (c *commandVolumeTierUpload) IsResourceHeavy() bool {
+func (c *commandVolumeTierUpload) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_unmount.go

@@ -34,7 +34,7 @@ func (c *commandVolumeUnmount) Help() string {
 `
 }
 
-func (c *commandVolumeUnmount) IsResourceHeavy() bool {
+func (c *commandVolumeUnmount) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_vacuum.go

@@ -27,7 +27,7 @@ func (c *commandVacuum) Help() string {
 `
 }
 
-func (c *commandVacuum) IsResourceHeavy() bool {
+func (c *commandVacuum) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_vacuum_disable.go

@@ -26,7 +26,7 @@ func (c *commandDisableVacuum) Help() string {
 `
 }
 
-func (c *commandDisableVacuum) IsResourceHeavy() bool {
+func (c *commandDisableVacuum) HasTag(CommandTag) bool {
 	return false
 }
 

weed/shell/command_volume_vacuum_enable.go

@@ -26,7 +26,7 @@ func (c *commandEnableVacuum) Help() string {
 `
 }
 
-func (c *commandEnableVacuum) IsResourceHeavy() bool {
+func (c *commandEnableVacuum) HasTag(CommandTag) bool {
 	return false
 }