From e8e50ebc75202fccb6a0c3554a44a7514af65844 Mon Sep 17 00:00:00 2001 From: chrislu Date: Thu, 30 Oct 2025 19:54:37 -0700 Subject: [PATCH] add a comment --- weed/wdclient/masterclient.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/weed/wdclient/masterclient.go b/weed/wdclient/masterclient.go index 57523c8ec..f3950bc37 100644 --- a/weed/wdclient/masterclient.go +++ b/weed/wdclient/masterclient.go @@ -35,6 +35,9 @@ type MasterClient struct { masters pb.ServerDiscovery grpcDialOption grpc.DialOption + // TODO: CRITICAL - Data race: resetVidMap() writes to vidMap while other methods read concurrently + // This embedded *vidMap should be changed to a private field protected by sync.RWMutex + // See: https://github.com/seaweedfs/seaweedfs/issues/[ISSUE_NUMBER] *vidMap vidMapCacheSize int OnPeerUpdate func(update *master_pb.ClusterNodeUpdate, startFrom time.Time)