return error early

fix https://github.com/chrislusf/seaweedfs/issues/2370
3 years ago · e6ef7b2387
1 changed files with 4 additions and 4 deletions
--- a/weed/operation/assign_file_id.go
+++ b/weed/operation/assign_file_id.go
@ -66,6 +66,10 @@ func Assign(masterFn GetMasterFn, grpcDialOption grpc.DialOption, primaryRequest
 				return grpcErr
 			}

+			if resp.Error != "" {
+				return fmt.Errorf("assignRequest: %v", resp.Error)
+			}
+
 			ret.Count = resp.Count
 			ret.Fid = resp.Fid
 			ret.Url = resp.Location.Url
@ -80,10 +84,6 @@ func Assign(masterFn GetMasterFn, grpcDialOption grpc.DialOption, primaryRequest
 				})
 			}

-			if resp.Error != "" {
-				return fmt.Errorf("assignRequest: %v", resp.Error)
-			}
-
 			return nil

 		})