diff --git a/weed/filer/reader_at.go b/weed/filer/reader_at.go index 04c64d449..3890bfe54 100644 --- a/weed/filer/reader_at.go +++ b/weed/filer/reader_at.go @@ -5,6 +5,7 @@ import ( "fmt" "github.com/chrislusf/seaweedfs/weed/glog" "github.com/chrislusf/seaweedfs/weed/pb/filer_pb" + "github.com/chrislusf/seaweedfs/weed/util" "github.com/chrislusf/seaweedfs/weed/util/chunk_cache" "github.com/chrislusf/seaweedfs/weed/wdclient" "github.com/golang/groupcache/singleflight" @@ -45,34 +46,29 @@ func LookupFn(filerClient filer_pb.FilerClient) LookupFileIdFunctionType { locations, found := vidCache[vid] vicCacheLock.RUnlock() - waitTime := time.Second - for !found && waitTime < ReadWaitTime { - // println("looking up volume", vid) - err = filerClient.WithFilerClient(func(client filer_pb.SeaweedFilerClient) error { - resp, err := client.LookupVolume(context.Background(), &filer_pb.LookupVolumeRequest{ - VolumeIds: []string{vid}, + if !found { + util.Retry("lookup volume "+vid, ReadWaitTime, func() error { + err = filerClient.WithFilerClient(func(client filer_pb.SeaweedFilerClient) error { + resp, err := client.LookupVolume(context.Background(), &filer_pb.LookupVolumeRequest{ + VolumeIds: []string{vid}, + }) + if err != nil { + return err + } + + locations = resp.LocationsMap[vid] + if locations == nil || len(locations.Locations) == 0 { + glog.V(0).Infof("failed to locate %s", fileId) + return fmt.Errorf("failed to locate %s", fileId) + } + vicCacheLock.Lock() + vidCache[vid] = locations + vicCacheLock.Unlock() + + return nil }) - if err != nil { - return err - } - - locations = resp.LocationsMap[vid] - if locations == nil || len(locations.Locations) == 0 { - glog.V(0).Infof("failed to locate %s", fileId) - return fmt.Errorf("failed to locate %s", fileId) - } - vicCacheLock.Lock() - vidCache[vid] = locations - vicCacheLock.Unlock() - - return nil + return err }) - if err == nil { - break - } - glog.V(1).Infof("wait for volume %s", vid) - time.Sleep(waitTime) - waitTime += waitTime / 2 } if err != nil { diff --git a/weed/filesys/meta_cache/meta_cache_init.go b/weed/filesys/meta_cache/meta_cache_init.go index f42d61230..3461babcb 100644 --- a/weed/filesys/meta_cache/meta_cache_init.go +++ b/weed/filesys/meta_cache/meta_cache_init.go @@ -3,8 +3,6 @@ package meta_cache import ( "context" "fmt" - "strings" - "time" "github.com/chrislusf/seaweedfs/weed/filer" "github.com/chrislusf/seaweedfs/weed/glog" @@ -18,7 +16,7 @@ func EnsureVisited(mc *MetaCache, client filer_pb.FilerClient, dirPath util.Full glog.V(4).Infof("ReadDirAllEntries %s ...", path) - for waitTime := time.Second; waitTime < filer.ReadWaitTime; waitTime += waitTime / 2 { + util.Retry("ReadDirAllEntries", filer.ReadWaitTime, func() error { err = filer_pb.ReadDirAllEntries(client, dirPath, "", func(pbEntry *filer_pb.Entry, isLast bool) error { entry := filer.FromPbEntry(string(dirPath), pbEntry) if err := mc.doInsertEntry(context.Background(), entry); err != nil { @@ -30,17 +28,13 @@ func EnsureVisited(mc *MetaCache, client filer_pb.FilerClient, dirPath util.Full } return nil }) - if err == nil { - break - } - if strings.Contains(err.Error(), "transport: ") { - glog.V(0).Infof("ReadDirAllEntries %s: %v. Retry in %v", path, err, waitTime) - time.Sleep(waitTime) - continue - } + return err + }) + + if err != nil { err = fmt.Errorf("list %s: %v", dirPath, err) - break } + return }) }