From df3f30874055834bb2423cfe538bdbadf922f5cd Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Wed, 14 Jan 2026 13:14:14 -0800 Subject: [PATCH] s3api: use updateAuthenticationState helper and clarified log message --- weed/s3api/auth_credentials.go | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/weed/s3api/auth_credentials.go b/weed/s3api/auth_credentials.go index 6ec22ca41..06cd94300 100644 --- a/weed/s3api/auth_credentials.go +++ b/weed/s3api/auth_credentials.go @@ -477,11 +477,7 @@ func (iam *IdentityAccessManagement) replaceS3ApiConfiguration(config *iam_pb.S3 iam.nameToIdentity = nameToIdentity // Update authentication state based on whether identities exist // Once enabled, keep it enabled (one-way toggle) - authJustEnabled := false - if !iam.isAuthEnabled && len(identities) > 0 { - iam.isAuthEnabled = true - authJustEnabled = true - } + authJustEnabled := iam.updateAuthenticationState(len(identities)) iam.m.Unlock() if authJustEnabled { @@ -701,15 +697,11 @@ func (iam *IdentityAccessManagement) mergeS3ApiConfiguration(config *iam_pb.S3Ap iam.nameToIdentity = nameToIdentity // Update authentication state based on whether identities exist // Once enabled, keep it enabled (one-way toggle) - authJustEnabled := false - if !iam.isAuthEnabled && len(identities) > 0 { - iam.isAuthEnabled = true - authJustEnabled = true - } + authJustEnabled := iam.updateAuthenticationState(len(identities)) iam.m.Unlock() if authJustEnabled { - glog.V(0).Infof("S3 authentication enabled - credentials were added dynamically") + glog.V(0).Infof("S3 authentication enabled because credentials were added dynamically") } // Log configuration summary