From b3076909d1c7d3d55d49f7c9e1b28974beaa3a05 Mon Sep 17 00:00:00 2001 From: guosj <515878133@qq.com> Date: Tue, 12 Jul 2022 11:25:36 +0800 Subject: [PATCH] refactor code --- weed/iamapi/iamapi_management_handlers.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/weed/iamapi/iamapi_management_handlers.go b/weed/iamapi/iamapi_management_handlers.go index fdd943b28..561c6e770 100644 --- a/weed/iamapi/iamapi_management_handlers.go +++ b/weed/iamapi/iamapi_management_handlers.go @@ -213,23 +213,18 @@ func (iama *IamApiServer) PutUserPolicy(s3cfg *iam_pb.S3ApiConfiguration, values if err != nil { return PutUserPolicyResponse{}, err } - isFound := false policyDocuments[policyName] = &policyDocument actions := GetActions(&policyDocument) for _, ident := range s3cfg.Identities { if userName != ident.Name { continue } - isFound = true for _, action := range actions { ident.Actions = append(ident.Actions, action) } - break - } - if !isFound { - return resp, fmt.Errorf("%s: the user with name %s cannot be found", iam.ErrCodeNoSuchEntityException, userName) + return resp, nil } - return resp, nil + return resp, fmt.Errorf("%s: the user with name %s cannot be found", iam.ErrCodeNoSuchEntityException, userName) } func (iama *IamApiServer) GetUserPolicy(s3cfg *iam_pb.S3ApiConfiguration, values url.Values) (resp GetUserPolicyResponse, err error) {