From dbf6465b0eff5287a2bcfe205a23f803fee7a4e9 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Wed, 28 Jan 2026 16:24:15 -0800 Subject: [PATCH] s3tables: Add log message when cluster shutdown times out The timeout path (2 second wait for graceful shutdown) was silent. Add a warning log message when it occurs to help diagnose flaky test issues and indicate when the mini cluster didn't shut down cleanly. --- test/s3tables/s3tables_integration_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/s3tables/s3tables_integration_test.go b/test/s3tables/s3tables_integration_test.go index ffcab9b33..da0400bf7 100644 --- a/test/s3tables/s3tables_integration_test.go +++ b/test/s3tables/s3tables_integration_test.go @@ -525,6 +525,8 @@ func (c *TestCluster) Stop() { // Goroutine finished case <-timer.C: // Timeout - goroutine doesn't respond to context cancel + // This may indicate the mini cluster didn't shut down cleanly + c.t.Log("Warning: Test cluster shutdown timed out after 2 seconds") } // Reset the global cmdMini flags to prevent state leakage to other tests