diff --git a/weed/command/filer_backup.go b/weed/command/filer_backup.go index 82df2ca7d..6f379a6d6 100644 --- a/weed/command/filer_backup.go +++ b/weed/command/filer_backup.go @@ -86,11 +86,6 @@ func doFilerBackup(grpcDialOption grpc.DialOption, backupOption *FilerBackupOpti if dataSink == nil { return fmt.Errorf("no data sink configured in replication.toml") } - if config.GetBool("source.filer.enabled") { - *backupOption.filer = config.GetString("source.filer.address") - *backupOption.path = config.GetString("source.filer.directory") - *backupOption.excludePaths = config.GetString("source.filer.excludeDirectories") - } sourceFiler := pb.ServerAddress(*backupOption.filer) sourcePath := *backupOption.path diff --git a/weed/command/filer_replication.go b/weed/command/filer_replication.go index acd512009..ec965a5e3 100644 --- a/weed/command/filer_replication.go +++ b/weed/command/filer_replication.go @@ -59,7 +59,7 @@ func runFilerReplicate(cmd *Command, args []string) bool { // avoid recursive replication if config.GetBool("notification.source.filer.enabled") && config.GetBool("notification.sink.filer.enabled") { - if config.GetString("source.filer.address") == config.GetString("sink.filer.address") { + if config.GetString("source.filer.grpcAddress") == config.GetString("sink.filer.grpcAddress") { fromDir := config.GetString("source.filer.directory") toDir := config.GetString("sink.filer.directory") if strings.HasPrefix(toDir, fromDir) { diff --git a/weed/command/scaffold/replication.toml b/weed/command/scaffold/replication.toml index 4c88f834b..cffe1b76f 100644 --- a/weed/command/scaffold/replication.toml +++ b/weed/command/scaffold/replication.toml @@ -8,7 +8,7 @@ [source.filer] # deprecated. Only useful with "weed filer.replicate" enabled = true -address = "localhost:8888" +grpcAddress = "localhost:18888" # all files under this directory tree are replicated. # this is not a directory on your hard drive, but on your filer. # i.e., all files with this "prefix" are sent to notification message queue. @@ -25,7 +25,7 @@ is_incremental = false [sink.filer] enabled = false -address = "localhost:8888" +grpcAddress = "localhost:18888" # all replicated files are under this directory tree # this is not a directory on your hard drive, but on your filer. # i.e., all received files will be "prefixed" to this directory. diff --git a/weed/replication/sink/filersink/filer_sink.go b/weed/replication/sink/filersink/filer_sink.go index 8b980775f..de5ff55cc 100644 --- a/weed/replication/sink/filersink/filer_sink.go +++ b/weed/replication/sink/filersink/filer_sink.go @@ -54,10 +54,9 @@ func (fs *FilerSink) IsIncremental() bool { func (fs *FilerSink) Initialize(configuration util.Configuration, prefix string) error { fs.isIncremental = configuration.GetBool(prefix + "is_incremental") fs.dataCenter = configuration.GetString(prefix + "dataCenter") - filerAddress := pb.ServerAddress(configuration.GetString(prefix + "address")) return fs.DoInitialize( - filerAddress.ToHttpAddress(), - filerAddress.ToGrpcAddress(), + "", + configuration.GetString(prefix+"grpcAddress"), configuration.GetString(prefix+"directory"), configuration.GetString(prefix+"replication"), configuration.GetString(prefix+"collection"), diff --git a/weed/replication/source/filer_source.go b/weed/replication/source/filer_source.go index d15b2a574..2da883ba6 100644 --- a/weed/replication/source/filer_source.go +++ b/weed/replication/source/filer_source.go @@ -32,10 +32,9 @@ type FilerSource struct { func (fs *FilerSource) Initialize(configuration util.Configuration, prefix string) error { fs.dataCenter = configuration.GetString(prefix + "dataCenter") - filerAddress := pb.ServerAddress(configuration.GetString(prefix + "address")) return fs.DoInitialize( - filerAddress.ToHttpAddress(), - filerAddress.ToGrpcAddress(), + "", + configuration.GetString(prefix+"grpcAddress"), configuration.GetString(prefix+"directory"), false, )