From c04b7b411c6eafd2c9ae15ce68a907a02541df83 Mon Sep 17 00:00:00 2001 From: Joon Young Baik <110450904+baikjy0215@users.noreply.github.com> Date: Fri, 11 Jul 2025 00:50:20 +1200 Subject: [PATCH] refactor: Performance and readability improvement on isDefaultPort (#6960) --- weed/s3api/auth_signature_v4.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/weed/s3api/auth_signature_v4.go b/weed/s3api/auth_signature_v4.go index c70027106..0ddbaa917 100644 --- a/weed/s3api/auth_signature_v4.go +++ b/weed/s3api/auth_signature_v4.go @@ -763,9 +763,14 @@ func isDefaultPort(scheme, port string) bool { return true } - lowerCaseScheme := strings.ToLower(scheme) - return (lowerCaseScheme == "http" && port == "80") || - (lowerCaseScheme == "https" && port == "443") + switch port { + case "80": + return strings.EqualFold(scheme, "http") + case "443": + return strings.EqualFold(scheme, "https") + default: + return false + } } // getSignedHeaders generate a string i.e alphabetically sorted, semicolon-separated list of lowercase request header names