From b78b521a8a52db55ad1670d7a6b1f377469dee30 Mon Sep 17 00:00:00 2001 From: chrislu Date: Tue, 25 Nov 2025 12:02:18 -0800 Subject: [PATCH] fix copying for paused versioning buckets --- weed/s3api/s3api_object_handlers_copy.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/weed/s3api/s3api_object_handlers_copy.go b/weed/s3api/s3api_object_handlers_copy.go index 91da98a0e..4852205cc 100644 --- a/weed/s3api/s3api_object_handlers_copy.go +++ b/weed/s3api/s3api_object_handlers_copy.go @@ -230,10 +230,11 @@ func (s3a *S3ApiServer) CopyObjectHandler(w http.ResponseWriter, r *http.Request } } - // Check if destination bucket has versioning configured - dstVersioningConfigured, err := s3a.isVersioningConfigured(dstBucket) + // Check if destination bucket has versioning enabled + // Only create versions if versioning is explicitly "Enabled", not "Suspended" or unconfigured + dstVersioningState, err := s3a.getVersioningState(dstBucket) if err != nil { - glog.Errorf("Error checking versioning status for destination bucket %s: %v", dstBucket, err) + glog.Errorf("Error checking versioning state for destination bucket %s: %v", dstBucket, err) s3err.WriteErrorResponse(w, r, s3err.ErrInternalError) return } @@ -241,7 +242,7 @@ func (s3a *S3ApiServer) CopyObjectHandler(w http.ResponseWriter, r *http.Request var dstVersionId string var etag string - if dstVersioningConfigured { + if dstVersioningState == s3_constants.VersioningEnabled { // For versioned destination, create a new version dstVersionId = generateVersionId() glog.V(2).Infof("CopyObjectHandler: creating version %s for destination %s/%s", dstVersionId, dstBucket, dstObject)