From b5d6334309211728e25130bf8015105eb1e29564 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Wed, 18 Mar 2026 11:30:31 -0700 Subject: [PATCH] fix set_writable to not modify no_write_can_delete Go's MarkVolumeWritable only sets noWriteOrDelete=false and persists. Rust was additionally setting no_write_can_delete=has_remote_file, which could incorrectly change the write mode for remote-file volumes when the master explicitly asks to make the volume writable. --- seaweed-volume/src/storage/volume.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/seaweed-volume/src/storage/volume.rs b/seaweed-volume/src/storage/volume.rs index 6277181b0..573940ca5 100644 --- a/seaweed-volume/src/storage/volume.rs +++ b/seaweed-volume/src/storage/volume.rs @@ -2070,7 +2070,6 @@ impl Volume { /// Mark this volume as writable (allow writes and deletes). pub fn set_writable(&mut self) -> Result<(), VolumeError> { self.no_write_or_delete = false; - self.no_write_can_delete = self.has_remote_file; self.save_vif() }