From b3696024d118fd13aff0fc5e94010ee3d17d4dc9 Mon Sep 17 00:00:00 2001 From: chrislu Date: Tue, 20 Aug 2024 09:39:35 -0700 Subject: [PATCH] add warning for not enough copies when skipping vacuuming volumes fix https://github.com/seaweedfs/seaweedfs/issues/5906 --- weed/topology/topology_vacuum.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/weed/topology/topology_vacuum.go b/weed/topology/topology_vacuum.go index f5b1eaaff..b1a8b66d4 100644 --- a/weed/topology/topology_vacuum.go +++ b/weed/topology/topology_vacuum.go @@ -270,7 +270,11 @@ func (t *Topology) vacuumOneVolumeId(grpcDialOption grpc.DialOption, volumeLayou isEnoughCopies := volumeLayout.enoughCopies(vid) volumeLayout.accessLock.RUnlock() - if isReadOnly || !isEnoughCopies { + if isReadOnly { + return + } + if !isEnoughCopies { + glog.Warningf("skip vacuuming: not enough copies for volume:%d", vid) return }