From a61af2989c8b7dde766cedb1a25d86737aeecc29 Mon Sep 17 00:00:00 2001
From: chrislu <chris.lu@gmail.com>
Date: Sat, 22 Nov 2025 13:52:27 -0800
Subject: [PATCH] ci: add comprehensive failure diagnostics

- Add container status (docker compose ps -a) on startup failure
- Add detailed logs for all three services (master, volume, filer)
- Add container inspection to verify binary exists
- Add debugging info for spark-example job
- Helps diagnose startup failures before containers are torn down
---
 .github/workflows/spark-integration-tests.yml | 32 +++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/spark-integration-tests.yml b/.github/workflows/spark-integration-tests.yml
index 0cdc3b730..9896221da 100644
--- a/.github/workflows/spark-integration-tests.yml
+++ b/.github/workflows/spark-integration-tests.yml
@@ -150,7 +150,21 @@ jobs:
           fi
           if [ $i -eq 30 ]; then
             echo "✗ SeaweedFS failed to start after 60 seconds"
-            docker compose logs
+            echo ""
+            echo "=== Container Status ==="
+            docker compose ps -a
+            echo ""
+            echo "=== Master Container Logs ==="
+            docker compose logs seaweedfs-master
+            echo ""
+            echo "=== Volume Container Logs ==="
+            docker compose logs seaweedfs-volume
+            echo ""
+            echo "=== Filer Container Logs ==="
+            docker compose logs seaweedfs-filer
+            echo ""
+            echo "=== Inspecting master container ==="
+            docker compose exec -T seaweedfs-master ls -la /usr/bin/weed || echo "Failed to inspect container"
             exit 1
           fi
           echo "Waiting... ($i/30)"
@@ -258,9 +272,11 @@ jobs:
     - name: Prepare SeaweedFS binary
       run: |
         echo "Copying SeaweedFS binary to docker directory..."
+        ls -la build-artifacts/docker/
         cp build-artifacts/docker/weed docker/
         chmod +x docker/weed
         ls -la docker/weed
+        file docker/weed
         echo "✓ Binary is ready"
 
     - name: Cache Apache Spark
@@ -287,6 +303,7 @@ jobs:
       working-directory: test/java/spark
       run: |
         echo "Starting SeaweedFS with Docker Compose..."
+        docker compose build --no-cache
         docker compose up -d seaweedfs-master seaweedfs-volume seaweedfs-filer
         
         echo "Waiting for SeaweedFS filer to be ready..."
@@ -297,7 +314,18 @@ jobs:
           fi
           if [ $i -eq 30 ]; then
             echo "✗ SeaweedFS failed to start after 60 seconds"
-            docker compose logs
+            echo ""
+            echo "=== Container Status ==="
+            docker compose ps -a
+            echo ""
+            echo "=== Master Container Logs ==="
+            docker compose logs seaweedfs-master
+            echo ""
+            echo "=== Volume Container Logs ==="
+            docker compose logs seaweedfs-volume
+            echo ""
+            echo "=== Filer Container Logs ==="
+            docker compose logs seaweedfs-filer
             exit 1
           fi
           echo "Waiting... ($i/30)"