From a192373c251c821bf35a7e614cd286a28667071d Mon Sep 17 00:00:00 2001 From: Jianfei Wang Date: Sun, 10 Apr 2016 13:47:03 +0800 Subject: [PATCH] storage: do not copy sync.Mutex by value --- go/storage/needle_map.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/go/storage/needle_map.go b/go/storage/needle_map.go index 41f53b90b..13fe4ffb1 100644 --- a/go/storage/needle_map.go +++ b/go/storage/needle_map.go @@ -39,7 +39,7 @@ type baseNeedleMapper struct { mapMetric } -func (nm baseNeedleMapper) IndexFileSize() uint64 { +func (nm *baseNeedleMapper) IndexFileSize() uint64 { stat, err := nm.indexFile.Stat() if err == nil { return uint64(stat.Size()) @@ -47,7 +47,7 @@ func (nm baseNeedleMapper) IndexFileSize() uint64 { return 0 } -func (nm baseNeedleMapper) IndexFileName() string { +func (nm *baseNeedleMapper) IndexFileName() string { return nm.indexFile.Name() } @@ -57,7 +57,7 @@ func idxFileEntry(bytes []byte) (key uint64, offset uint32, size uint32) { size = binary.BigEndian.Uint32(bytes[12:16]) return } -func (nm baseNeedleMapper) appendToIndexFile(key uint64, offset uint32, size uint32) error { +func (nm *baseNeedleMapper) appendToIndexFile(key uint64, offset uint32, size uint32) error { bytes := make([]byte, 16) binary.BigEndian.PutUint64(bytes[0:8], key) binary.BigEndian.PutUint32(bytes[8:12], offset) @@ -72,7 +72,7 @@ func (nm baseNeedleMapper) appendToIndexFile(key uint64, offset uint32, size uin _, err := nm.indexFile.Write(bytes) return err } -func (nm baseNeedleMapper) IndexFileContent() ([]byte, error) { +func (nm *baseNeedleMapper) IndexFileContent() ([]byte, error) { nm.indexFileAccessLock.Lock() defer nm.indexFileAccessLock.Unlock() return ioutil.ReadFile(nm.indexFile.Name())