diff --git a/weed/s3api/s3api_bucket_handlers_object_lock_config.go b/weed/s3api/s3api_bucket_handlers_object_lock_config.go index 494f203a4..a0f9ba938 100644 --- a/weed/s3api/s3api_bucket_handlers_object_lock_config.go +++ b/weed/s3api/s3api_bucket_handlers_object_lock_config.go @@ -32,7 +32,7 @@ func (s3a *S3ApiServer) PutObjectLockConfigurationHandler(w http.ResponseWriter, // Validate object lock configuration if err := validateObjectLockConfiguration(config); err != nil { glog.Errorf("PutObjectLockConfigurationHandler: invalid object lock config: %v", err) - s3err.WriteErrorResponse(w, r, s3err.ErrInvalidRequest) + s3err.WriteErrorResponse(w, r, mapValidationErrorToS3Error(err)) return } diff --git a/weed/s3api/s3api_object_handlers_legal_hold.go b/weed/s3api/s3api_object_handlers_legal_hold.go index e89c65c02..4010ff426 100644 --- a/weed/s3api/s3api_object_handlers_legal_hold.go +++ b/weed/s3api/s3api_object_handlers_legal_hold.go @@ -36,7 +36,7 @@ func (s3a *S3ApiServer) PutObjectLegalHoldHandler(w http.ResponseWriter, r *http // Validate legal hold configuration if err := validateLegalHold(legalHold); err != nil { glog.Errorf("PutObjectLegalHoldHandler: invalid legal hold config: %v", err) - s3err.WriteErrorResponse(w, r, s3err.ErrInvalidRequest) + s3err.WriteErrorResponse(w, r, mapValidationErrorToS3Error(err)) return } diff --git a/weed/s3api/s3api_object_handlers_put.go b/weed/s3api/s3api_object_handlers_put.go index a52fd90b4..d2c774aee 100644 --- a/weed/s3api/s3api_object_handlers_put.go +++ b/weed/s3api/s3api_object_handlers_put.go @@ -566,8 +566,8 @@ func mapValidationErrorToS3Error(err error) s3err.ErrorCode { case errors.Is(err, ErrInvalidRetentionDateFormat): return s3err.ErrMalformedXML case errors.Is(err, ErrInvalidRetentionPeriod): - // For invalid retention periods (days/years), return MalformedXML - return s3err.ErrMalformedXML + // For invalid retention periods (days/years), return InvalidRetentionPeriod + return s3err.ErrInvalidRetentionPeriod case errors.Is(err, ErrInvalidRetentionMode): // For invalid retention modes, return MalformedXML return s3err.ErrMalformedXML diff --git a/weed/s3api/s3api_object_handlers_retention.go b/weed/s3api/s3api_object_handlers_retention.go index 9a6e7be32..687a95955 100644 --- a/weed/s3api/s3api_object_handlers_retention.go +++ b/weed/s3api/s3api_object_handlers_retention.go @@ -39,7 +39,7 @@ func (s3a *S3ApiServer) PutObjectRetentionHandler(w http.ResponseWriter, r *http // Validate retention configuration if err := validateRetention(retention); err != nil { glog.Errorf("PutObjectRetentionHandler: invalid retention config: %v", err) - s3err.WriteErrorResponse(w, r, s3err.ErrInvalidRequest) + s3err.WriteErrorResponse(w, r, mapValidationErrorToS3Error(err)) return } diff --git a/weed/s3api/s3api_object_retention.go b/weed/s3api/s3api_object_retention.go index 87d780228..5d4f846ab 100644 --- a/weed/s3api/s3api_object_retention.go +++ b/weed/s3api/s3api_object_retention.go @@ -656,9 +656,9 @@ func (s3a *S3ApiServer) handleObjectLockAvailabilityCheck(w http.ResponseWriter, if errors.Is(err, ErrBucketNotFound) { s3err.WriteErrorResponse(w, request, s3err.ErrNoSuchBucket) } else { - // Return 409 Conflict for object lock operations on buckets without object lock enabled + // Return InvalidBucketState for object lock operations on buckets without object lock enabled // This matches AWS S3 behavior and s3-tests expectations - s3err.WriteErrorResponse(w, request, s3err.ErrBucketNotEmpty) // This maps to 409 Conflict + s3err.WriteErrorResponse(w, request, s3err.ErrInvalidBucketState) } return false } diff --git a/weed/s3api/s3err/s3api_errors.go b/weed/s3api/s3err/s3api_errors.go index 146bd9871..12608ac21 100644 --- a/weed/s3api/s3err/s3api_errors.go +++ b/weed/s3api/s3err/s3api_errors.go @@ -113,6 +113,7 @@ const ( ErrNoSuchTagSet ErrNoSuchObjectLockConfiguration ErrNoSuchObjectLegalHold + ErrInvalidRetentionPeriod ) // Error message constants for checksum validation @@ -215,6 +216,11 @@ var errorCodeResponse = map[ErrorCode]APIError{ Description: "The specified object does not have a legal hold configuration", HTTPStatusCode: http.StatusNotFound, }, + ErrInvalidRetentionPeriod: { + Code: "InvalidRetentionPeriod", + Description: "The retention period specified is invalid", + HTTPStatusCode: http.StatusBadRequest, + }, ErrNoSuchCORSConfiguration: { Code: "NoSuchCORSConfiguration", Description: "The CORS configuration does not exist",