From 88fa64a01ae7ac8782e70dd29a8a9f6bf44a7e19 Mon Sep 17 00:00:00 2001 From: "steve.wei" Date: Wed, 27 Nov 2024 00:35:41 +0800 Subject: [PATCH] change comment for expect header (#6289) * remove case of expect * Set the default value of the Expect header for compatibility. --- weed/s3api/auth_signature_v4.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/weed/s3api/auth_signature_v4.go b/weed/s3api/auth_signature_v4.go index 9cc3e2766..2aa5a9e01 100644 --- a/weed/s3api/auth_signature_v4.go +++ b/weed/s3api/auth_signature_v4.go @@ -666,9 +666,10 @@ func extractSignedHeaders(signedHeaders []string, r *http.Request) (http.Header, } switch header { case "expect": - // Golang http server strips off 'Expect' header, if the - // client sent this as part of signed headers we need to - // handle otherwise we would see a signature mismatch. + // Set the default value of the Expect header for compatibility. + // + // In NGINX v1.1, the Expect header is removed when handling 100-continue requests. + // // `aws-cli` sets this as part of signed headers. // // According to @@ -680,8 +681,6 @@ func extractSignedHeaders(signedHeaders []string, r *http.Request) (http.Header, // // So it safe to assume that '100-continue' is what would // be sent, for the time being keep this work around. - // Adding a *TODO* to remove this later when Golang server - // doesn't filter out the 'Expect' header. extractedSignedHeaders.Set(header, "100-continue") case "host": // Go http server removes "host" from Request.Header