From 85aa6e345bf72f64a7ec448a3485a43f78847081 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 8 Mar 2026 20:52:01 -0700 Subject: [PATCH] docs: explain why group methods skip propagateChange Group changes propagate to S3 servers via filer subscription (watching /etc/iam/groups/) rather than gRPC RPCs, since there are no group-specific RPCs in the S3 cache protocol. --- weed/credential/propagating_store.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/weed/credential/propagating_store.go b/weed/credential/propagating_store.go index d43ec6746..86ba48d74 100644 --- a/weed/credential/propagating_store.go +++ b/weed/credential/propagating_store.go @@ -386,6 +386,10 @@ func (s *PropagatingCredentialStore) DeleteServiceAccount(ctx context.Context, i return nil } +// Group methods do not call propagateChange because there are no group-specific +// gRPC RPCs in the S3 cache protocol. Group changes are propagated to S3 servers +// via the filer subscription mechanism (watching /etc/iam/groups/ directory). + func (s *PropagatingCredentialStore) CreateGroup(ctx context.Context, group *iam_pb.Group) error { glog.V(4).Infof("IAM: PropagatingCredentialStore.CreateGroup %s", group.Name) return s.CredentialStore.CreateGroup(ctx, group)