From 7f1c492762dd90f1b6b413fc428548a309743aee Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Tue, 17 Mar 2026 15:48:16 -0700 Subject: [PATCH] Match Go privateStoreHandler: use INVALID as metrics label for unsupported methods Go records the method as INVALID in metrics for unsupported HTTP methods. Rust was using the actual method name. --- seaweed-volume/src/server/volume_server.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/seaweed-volume/src/server/volume_server.rs b/seaweed-volume/src/server/volume_server.rs index f2f07d152..5a01f412e 100644 --- a/seaweed-volume/src/server/volume_server.rs +++ b/seaweed-volume/src/server/volume_server.rs @@ -196,7 +196,7 @@ async fn common_headers_middleware(request: Request, next: Next) -> Response { async fn admin_store_handler(state: State>, request: Request) -> Response { let start = std::time::Instant::now(); let method = request.method().clone(); - let method_str = method.as_str().to_string(); + let mut method_str = method.as_str().to_string(); let request_bytes = request .headers() .get(header::CONTENT_LENGTH) @@ -234,6 +234,7 @@ async fn admin_store_handler(state: State>, request: Requ _ => { let method_name = request.method().to_string(); let query = request.uri().query().map(|q| q.to_string()); + method_str = "INVALID".to_string(); handlers::json_error_with_query( StatusCode::BAD_REQUEST, format!("unsupported method {}", method_name),