From 692e1ad1be6af8cc8b1200e9100ecd4225bb304d Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sat, 31 Jan 2026 15:44:45 -0800 Subject: [PATCH] Remove dead code, skip stub tests with TODO comments --- weed/worker/tasks/table_maintenance/scheduling.go | 14 -------------- .../table_maintenance_integration_test.go | 4 ++++ .../table_maintenance/table_maintenance_test.go | 1 + 3 files changed, 5 insertions(+), 14 deletions(-) diff --git a/weed/worker/tasks/table_maintenance/scheduling.go b/weed/worker/tasks/table_maintenance/scheduling.go index a2c49dacd..6a759502b 100644 --- a/weed/worker/tasks/table_maintenance/scheduling.go +++ b/weed/worker/tasks/table_maintenance/scheduling.go @@ -3,7 +3,6 @@ package table_maintenance import ( "time" - "github.com/seaweedfs/seaweedfs/weed/pb/worker_pb" "github.com/seaweedfs/seaweedfs/weed/worker/tasks/base" "github.com/seaweedfs/seaweedfs/weed/worker/types" ) @@ -84,16 +83,3 @@ func Scheduling(task *types.TaskInput, runningTasks []*types.TaskInput, availabl return false } - -// CreateTaskFromDetectionResult creates typed task parameters from a detection result -func CreateTaskFromDetectionResult(result *types.TaskDetectionResult) *worker_pb.TaskParams { - // For table maintenance, the source is the table path - return &worker_pb.TaskParams{ - Sources: []*worker_pb.TaskSource{ - { - Node: result.Server, // Table path - }, - }, - Collection: result.Collection, // Table bucket name - } -} diff --git a/weed/worker/tasks/table_maintenance/table_maintenance_integration_test.go b/weed/worker/tasks/table_maintenance/table_maintenance_integration_test.go index 5df4d10ab..20c774180 100644 --- a/weed/worker/tasks/table_maintenance/table_maintenance_integration_test.go +++ b/weed/worker/tasks/table_maintenance/table_maintenance_integration_test.go @@ -13,6 +13,7 @@ import ( // These tests verify the complete workflow of table maintenance operations func TestTableMaintenanceWorkflow_Compaction(t *testing.T) { + t.Skip("TODO: Enable when actual executeCompaction implementation is complete") // Test the complete compaction workflow job := &TableMaintenanceJob{ JobType: JobTypeCompaction, @@ -60,6 +61,7 @@ func TestTableMaintenanceWorkflow_Compaction(t *testing.T) { } func TestTableMaintenanceWorkflow_SnapshotExpiration(t *testing.T) { + t.Skip("TODO: Enable when actual executeSnapshotExpiration implementation is complete") job := &TableMaintenanceJob{ JobType: JobTypeSnapshotExpiration, TableBucket: "test-bucket", @@ -92,6 +94,7 @@ func TestTableMaintenanceWorkflow_SnapshotExpiration(t *testing.T) { } func TestTableMaintenanceWorkflow_OrphanCleanup(t *testing.T) { + t.Skip("TODO: Enable when actual executeOrphanCleanup implementation is complete") job := &TableMaintenanceJob{ JobType: JobTypeOrphanCleanup, TableBucket: "test-bucket", @@ -124,6 +127,7 @@ func TestTableMaintenanceWorkflow_OrphanCleanup(t *testing.T) { } func TestTableMaintenanceWorkflow_ManifestRewrite(t *testing.T) { + t.Skip("TODO: Enable when actual executeManifestRewrite implementation is complete") job := &TableMaintenanceJob{ JobType: JobTypeManifestRewrite, TableBucket: "test-bucket", diff --git a/weed/worker/tasks/table_maintenance/table_maintenance_test.go b/weed/worker/tasks/table_maintenance/table_maintenance_test.go index 85616b9c3..d0be174e6 100644 --- a/weed/worker/tasks/table_maintenance/table_maintenance_test.go +++ b/weed/worker/tasks/table_maintenance/table_maintenance_test.go @@ -86,6 +86,7 @@ func TestTableMaintenanceTask_EstimateTime(t *testing.T) { } func TestTableMaintenanceTask_Execute(t *testing.T) { + t.Skip("TODO: Enable when actual execute* implementations are complete") job := &TableMaintenanceJob{ JobType: JobTypeCompaction, TableBucket: "test-bucket",