From 66099b74564fb2b448b80d2ee3fd8a25d23979d0 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 8 Mar 2026 20:43:13 -0700 Subject: [PATCH] fix: use require instead of assert to prevent nil dereference panic in CORS test The test used assert.NoError (non-fatal) for GetBucketCors, then immediately accessed getResp.CORSRules. When the API returns an error, getResp is nil causing a panic. Switch to require.NoError/NotNil/Len so the test stops before dereferencing a nil response. --- test/s3/cors/s3_cors_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/s3/cors/s3_cors_test.go b/test/s3/cors/s3_cors_test.go index 4d3d4555e..18a113d99 100644 --- a/test/s3/cors/s3_cors_test.go +++ b/test/s3/cors/s3_cors_test.go @@ -140,7 +140,7 @@ func TestCORSConfigurationManagement(t *testing.T) { Bucket: aws.String(bucketName), CORSConfiguration: corsConfig, }) - assert.NoError(t, err, "Should be able to put CORS configuration") + require.NoError(t, err, "Should be able to put CORS configuration") // Wait for metadata subscription to update cache time.Sleep(50 * time.Millisecond) @@ -149,9 +149,9 @@ func TestCORSConfigurationManagement(t *testing.T) { getResp, err := client.GetBucketCors(context.TODO(), &s3.GetBucketCorsInput{ Bucket: aws.String(bucketName), }) - assert.NoError(t, err, "Should be able to get CORS configuration") - assert.NotNil(t, getResp.CORSRules, "CORS configuration should not be nil") - assert.Len(t, getResp.CORSRules, 1, "Should have one CORS rule") + require.NoError(t, err, "Should be able to get CORS configuration") + require.NotNil(t, getResp.CORSRules, "CORS configuration should not be nil") + require.Len(t, getResp.CORSRules, 1, "Should have one CORS rule") rule := getResp.CORSRules[0] assert.Equal(t, []string{"*"}, rule.AllowedHeaders, "Allowed headers should match")