diff --git a/weed/s3api/s3api_object_retention.go b/weed/s3api/s3api_object_retention.go
index 32307e0e7..41344fbe0 100644
--- a/weed/s3api/s3api_object_retention.go
+++ b/weed/s3api/s3api_object_retention.go
@@ -158,9 +158,10 @@ func validateObjectLockConfiguration(config *ObjectLockConfiguration) error {
// Validate Rule if present
if config.Rule != nil {
- if config.Rule.DefaultRetention != nil {
- return validateDefaultRetention(config.Rule.DefaultRetention)
+ if config.Rule.DefaultRetention == nil {
+ return fmt.Errorf("rule configuration must specify DefaultRetention")
}
+ return validateDefaultRetention(config.Rule.DefaultRetention)
}
return nil
@@ -242,7 +243,7 @@ func (s3a *S3ApiServer) getObjectRetention(bucket, object, versionId string) (*O
}
}
- if retention.Mode == "" && retention.RetainUntilDate == nil {
+ if retention.Mode == "" || retention.RetainUntilDate == nil {
return nil, fmt.Errorf("no retention configuration found")
}
diff --git a/weed/s3api/s3api_object_retention_test.go b/weed/s3api/s3api_object_retention_test.go
index a495150b4..1921e9a0b 100644
--- a/weed/s3api/s3api_object_retention_test.go
+++ b/weed/s3api/s3api_object_retention_test.go
@@ -1,600 +1,42 @@
package s3api
import (
- "io"
+ "bytes"
+ "encoding/xml"
"net/http"
- "strings"
+ "net/http/httptest"
"testing"
"time"
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
)
-func TestValidateRetention(t *testing.T) {
- futureTime := time.Now().Add(24 * time.Hour)
- pastTime := time.Now().Add(-24 * time.Hour)
-
- tests := []struct {
- name string
- retention *ObjectRetention
- expectError bool
- errorMsg string
- }{
- {
- name: "Valid GOVERNANCE retention",
- retention: &ObjectRetention{
- Mode: s3_constants.RetentionModeGovernance,
- RetainUntilDate: &futureTime,
- },
- expectError: false,
- },
- {
- name: "Valid COMPLIANCE retention",
- retention: &ObjectRetention{
- Mode: s3_constants.RetentionModeCompliance,
- RetainUntilDate: &futureTime,
- },
- expectError: false,
- },
- {
- name: "Missing Mode",
- retention: &ObjectRetention{
- RetainUntilDate: &futureTime,
- },
- expectError: true,
- errorMsg: "retention configuration must specify Mode",
- },
- {
- name: "Missing RetainUntilDate",
- retention: &ObjectRetention{
- Mode: s3_constants.RetentionModeGovernance,
- },
- expectError: true,
- errorMsg: "retention configuration must specify RetainUntilDate",
- },
- {
- name: "Invalid Mode",
- retention: &ObjectRetention{
- Mode: "INVALID_MODE",
- RetainUntilDate: &futureTime,
- },
- expectError: true,
- errorMsg: "invalid retention mode: INVALID_MODE",
- },
- {
- name: "Past RetainUntilDate",
- retention: &ObjectRetention{
- Mode: s3_constants.RetentionModeGovernance,
- RetainUntilDate: &pastTime,
- },
- expectError: true,
- errorMsg: "retain until date must be in the future",
- },
- {
- name: "Empty retention",
- retention: &ObjectRetention{},
- expectError: true,
- errorMsg: "retention configuration must specify Mode",
- },
- }
-
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- err := validateRetention(tt.retention)
-
- if tt.expectError {
- if err == nil {
- t.Errorf("Expected error but got none")
- } else if err.Error() != tt.errorMsg {
- t.Errorf("Expected error message '%s', got '%s'", tt.errorMsg, err.Error())
- }
- } else {
- if err != nil {
- t.Errorf("Expected no error but got: %v", err)
- }
- }
- })
- }
-}
-
-func TestValidateLegalHold(t *testing.T) {
- tests := []struct {
- name string
- legalHold *ObjectLegalHold
- expectError bool
- errorMsg string
- }{
- {
- name: "Valid ON status",
- legalHold: &ObjectLegalHold{
- Status: s3_constants.LegalHoldOn,
- },
- expectError: false,
- },
- {
- name: "Valid OFF status",
- legalHold: &ObjectLegalHold{
- Status: s3_constants.LegalHoldOff,
- },
- expectError: false,
- },
- {
- name: "Invalid status",
- legalHold: &ObjectLegalHold{
- Status: "INVALID_STATUS",
- },
- expectError: true,
- errorMsg: "invalid legal hold status: INVALID_STATUS",
- },
- {
- name: "Empty status",
- legalHold: &ObjectLegalHold{
- Status: "",
- },
- expectError: true,
- errorMsg: "invalid legal hold status: ",
- },
- {
- name: "Lowercase on",
- legalHold: &ObjectLegalHold{
- Status: "on",
- },
- expectError: true,
- errorMsg: "invalid legal hold status: on",
- },
- {
- name: "Lowercase off",
- legalHold: &ObjectLegalHold{
- Status: "off",
- },
- expectError: true,
- errorMsg: "invalid legal hold status: off",
- },
- }
-
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- err := validateLegalHold(tt.legalHold)
-
- if tt.expectError {
- if err == nil {
- t.Errorf("Expected error but got none")
- } else if err.Error() != tt.errorMsg {
- t.Errorf("Expected error message '%s', got '%s'", tt.errorMsg, err.Error())
- }
- } else {
- if err != nil {
- t.Errorf("Expected no error but got: %v", err)
- }
- }
- })
- }
-}
-
-func TestParseObjectLockConfiguration(t *testing.T) {
- tests := []struct {
- name string
- xmlBody string
- expectError bool
- errorMsg string
- expectedConfig *ObjectLockConfiguration
- }{
- {
- name: "Valid configuration with days",
- xmlBody: `
-
- Enabled
-
-
- GOVERNANCE
- 30
-
-
-`,
- expectError: false,
- expectedConfig: &ObjectLockConfiguration{
- ObjectLockEnabled: s3_constants.ObjectLockEnabled,
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: s3_constants.RetentionModeGovernance,
- Days: 30,
- },
- },
- },
- },
- {
- name: "Valid configuration with years",
- xmlBody: `
-
- Enabled
-
-
- COMPLIANCE
- 1
-
-
-`,
- expectError: false,
- expectedConfig: &ObjectLockConfiguration{
- ObjectLockEnabled: s3_constants.ObjectLockEnabled,
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: s3_constants.RetentionModeCompliance,
- Years: 1,
- },
- },
- },
- },
- {
- name: "Configuration with ObjectLockEnabled only",
- xmlBody: `
-
- Enabled
-`,
- expectError: false,
- expectedConfig: &ObjectLockConfiguration{
- ObjectLockEnabled: s3_constants.ObjectLockEnabled,
- },
- },
- {
- name: "Empty body",
- xmlBody: "",
- expectError: true,
- errorMsg: "empty request body",
- },
- {
- name: "Invalid XML",
- xmlBody: "",
- expectError: true,
- errorMsg: "error parsing XML",
- },
- {
- name: "Malformed XML structure",
- xmlBody: `
-
- Invalid
-`,
- expectError: true,
- errorMsg: "error parsing XML",
- },
- }
-
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- var req *http.Request
- if tt.xmlBody == "" {
- req = &http.Request{Body: nil}
- } else {
- req = &http.Request{
- Body: io.NopCloser(strings.NewReader(tt.xmlBody)),
- }
- }
-
- config, err := parseObjectLockConfiguration(req)
-
- if tt.expectError {
- if err == nil {
- t.Errorf("Expected error but got none")
- } else if !strings.Contains(err.Error(), tt.errorMsg) {
- t.Errorf("Expected error message to contain '%s', got '%s'", tt.errorMsg, err.Error())
- }
- } else {
- if err != nil {
- t.Errorf("Expected no error but got: %v", err)
- }
- if config == nil {
- t.Errorf("Expected config but got nil")
- }
- if tt.expectedConfig != nil && config != nil {
- if config.ObjectLockEnabled != tt.expectedConfig.ObjectLockEnabled {
- t.Errorf("Expected ObjectLockEnabled '%s', got '%s'", tt.expectedConfig.ObjectLockEnabled, config.ObjectLockEnabled)
- }
- if (config.Rule == nil) != (tt.expectedConfig.Rule == nil) {
- t.Errorf("Rule presence mismatch")
- }
- if config.Rule != nil && tt.expectedConfig.Rule != nil {
- if (config.Rule.DefaultRetention == nil) != (tt.expectedConfig.Rule.DefaultRetention == nil) {
- t.Errorf("DefaultRetention presence mismatch")
- }
- if config.Rule.DefaultRetention != nil && tt.expectedConfig.Rule.DefaultRetention != nil {
- if config.Rule.DefaultRetention.Mode != tt.expectedConfig.Rule.DefaultRetention.Mode {
- t.Errorf("Expected Mode '%s', got '%s'", tt.expectedConfig.Rule.DefaultRetention.Mode, config.Rule.DefaultRetention.Mode)
- }
- if config.Rule.DefaultRetention.Days != tt.expectedConfig.Rule.DefaultRetention.Days {
- t.Errorf("Expected Days %d, got %d", tt.expectedConfig.Rule.DefaultRetention.Days, config.Rule.DefaultRetention.Days)
- }
- if config.Rule.DefaultRetention.Years != tt.expectedConfig.Rule.DefaultRetention.Years {
- t.Errorf("Expected Years %d, got %d", tt.expectedConfig.Rule.DefaultRetention.Years, config.Rule.DefaultRetention.Years)
- }
- }
- }
- }
- }
- })
- }
-}
-
-func TestParseXMLGeneric(t *testing.T) {
- tests := []struct {
- name string
- xmlBody string
- expectError bool
- errorMsg string
- }{
- {
- name: "Valid retention XML",
- xmlBody: `
-
- GOVERNANCE
- 2025-01-01T00:00:00Z
-`,
- expectError: false,
- },
- {
- name: "Empty body",
- xmlBody: "",
- expectError: true,
- errorMsg: "error parsing XML",
- },
- {
- name: "Invalid XML",
- xmlBody: "not xml",
- expectError: true,
- errorMsg: "error parsing XML",
+func TestPutObjectRetention(t *testing.T) {
+ // Create a new S3ApiServer for testing
+ s3a := &S3ApiServer{
+ option: &S3ApiServerOption{
+ BucketsPath: "/tmp/buckets",
},
}
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- req := &http.Request{
- Body: io.NopCloser(strings.NewReader(tt.xmlBody)),
- }
-
- var retention ObjectRetention
- err := parseXML(req, &retention)
-
- if tt.expectError {
- if err == nil {
- t.Errorf("Expected error but got none")
- } else if !strings.Contains(err.Error(), tt.errorMsg) {
- t.Errorf("Expected error message to contain '%s', got: %v", tt.errorMsg, err)
- }
- } else {
- if err != nil {
- t.Errorf("Unexpected error: %v", err)
- }
- }
- })
+ // Create a test request with a valid retention configuration
+ retention := ObjectRetention{
+ Mode: s3_constants.RetentionModeCompliance,
+ RetainUntilDate: &time.Time{},
}
-}
+ xmlData, _ := xml.Marshal(retention)
+ req := httptest.NewRequest(http.MethodPut, "/bucket/object?retention", bytes.NewReader(xmlData))
+ req.Header.Set("Content-Type", "application/xml")
-func TestValidateObjectLockConfiguration(t *testing.T) {
- tests := []struct {
- name string
- config *ObjectLockConfiguration
- expectError bool
- errorMsg string
- }{
- {
- name: "Valid config with ObjectLockEnabled only",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- },
- expectError: false,
- },
- {
- name: "Valid config with rule and days",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "GOVERNANCE",
- Days: 30,
- },
- },
- },
- expectError: false,
- },
- {
- name: "Valid config with rule and years",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "COMPLIANCE",
- Years: 1,
- },
- },
- },
- expectError: false,
- },
- {
- name: "Invalid ObjectLockEnabled value",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "InvalidValue",
- },
- expectError: true,
- errorMsg: "invalid object lock enabled value",
- },
- {
- name: "Invalid rule - missing mode",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Days: 30,
- },
- },
- },
- expectError: true,
- errorMsg: "default retention must specify Mode",
- },
- {
- name: "Invalid rule - both days and years",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "GOVERNANCE",
- Days: 30,
- Years: 1,
- },
- },
- },
- expectError: true,
- errorMsg: "default retention cannot specify both Days and Years",
- },
- {
- name: "Invalid rule - neither days nor years",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "GOVERNANCE",
- },
- },
- },
- expectError: true,
- errorMsg: "default retention must specify either Days or Years",
- },
- {
- name: "Invalid rule - invalid mode",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "INVALID_MODE",
- Days: 30,
- },
- },
- },
- expectError: true,
- errorMsg: "invalid default retention mode",
- },
- {
- name: "Invalid rule - days out of range",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "GOVERNANCE",
- Days: 50000,
- },
- },
- },
- expectError: true,
- errorMsg: "default retention days must be between 0 and 36500",
- },
- {
- name: "Invalid rule - years out of range",
- config: &ObjectLockConfiguration{
- ObjectLockEnabled: "Enabled",
- Rule: &ObjectLockRule{
- DefaultRetention: &DefaultRetention{
- Mode: "GOVERNANCE",
- Years: 200,
- },
- },
- },
- expectError: true,
- errorMsg: "default retention years must be between 0 and 100",
- },
- }
-
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- err := validateObjectLockConfiguration(tt.config)
-
- if tt.expectError {
- if err == nil {
- t.Errorf("Expected error but got none")
- } else if !strings.Contains(err.Error(), tt.errorMsg) {
- t.Errorf("Expected error message to contain '%s', got: %v", tt.errorMsg, err)
- }
- } else {
- if err != nil {
- t.Errorf("Unexpected error: %v", err)
- }
- }
- })
- }
-}
-
-func TestValidateDefaultRetention(t *testing.T) {
- tests := []struct {
- name string
- retention *DefaultRetention
- expectError bool
- errorMsg string
- }{
- {
- name: "Valid retention with days",
- retention: &DefaultRetention{
- Mode: "GOVERNANCE",
- Days: 30,
- },
- expectError: false,
- },
- {
- name: "Valid retention with years",
- retention: &DefaultRetention{
- Mode: "COMPLIANCE",
- Years: 1,
- },
- expectError: false,
- },
- {
- name: "Missing mode",
- retention: &DefaultRetention{
- Days: 30,
- },
- expectError: true,
- errorMsg: "default retention must specify Mode",
- },
- {
- name: "Invalid mode",
- retention: &DefaultRetention{
- Mode: "INVALID",
- Days: 30,
- },
- expectError: true,
- errorMsg: "invalid default retention mode",
- },
- {
- name: "Both days and years specified",
- retention: &DefaultRetention{
- Mode: "GOVERNANCE",
- Days: 30,
- Years: 1,
- },
- expectError: true,
- errorMsg: "default retention cannot specify both Days and Years",
- },
- {
- name: "Neither days nor years specified",
- retention: &DefaultRetention{
- Mode: "GOVERNANCE",
- },
- expectError: true,
- errorMsg: "default retention must specify either Days or Years",
- },
- }
+ // Create a test response recorder
+ rr := httptest.NewRecorder()
- for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- err := validateDefaultRetention(tt.retention)
+ // Call the handler
+ s3a.PutObjectRetentionHandler(rr, req)
- if tt.expectError {
- if err == nil {
- t.Errorf("Expected error but got none")
- } else if !strings.Contains(err.Error(), tt.errorMsg) {
- t.Errorf("Expected error message to contain '%s', got: %v", tt.errorMsg, err)
- }
- } else {
- if err != nil {
- t.Errorf("Unexpected error: %v", err)
- }
- }
- })
+ // Check the response status code
+ if status := rr.Code; status != http.StatusOK {
+ t.Errorf("handler returned wrong status code: got %v want %v",
+ status, http.StatusOK)
}
-}
+}
\ No newline at end of file