From 621ff124f0aab89fbbee23dd13a16179ef2c08a1 Mon Sep 17 00:00:00 2001
From: Chris Lu <chrislusf@users.noreply.github.com>
Date: Tue, 23 Dec 2025 10:33:21 -0800
Subject: [PATCH] fix: ensure Helm chart is published only after container
 images are available (#7859)

fix: consolidate Helm chart release with container image build

Resolve issue #7855 by consolidating the Helm chart release workflow
with the container image build workflow. This ensures perfect alignment:

1. Container images are built and pushed to GHCR
2. Images are copied from GHCR to Docker Hub
3. Helm chart is published only after step 2 completes

Previously, the Helm chart was published immediately on tag push before
images were available in Docker Hub, causing deployment failures.

Changes:
- Added helm-release job to container_release_unified.yml that depends
  on copy-to-dockerhub job
- Removed helm_chart_release.yml workflow (consolidated into unified release)

Benefits:
- No race conditions between image push and chart publication
- Users can deploy immediately after release
- Single source of truth for release process
- Clearer job dependencies and execution flow
---
 .../workflows/container_release_unified.yml   | 18 +++++++++++++++
 .github/workflows/helm_chart_release.yml      | 23 -------------------
 2 files changed, 18 insertions(+), 23 deletions(-)
 delete mode 100644 .github/workflows/helm_chart_release.yml

diff --git a/.github/workflows/container_release_unified.yml b/.github/workflows/container_release_unified.yml
index 9e3a0a451..8dedfd26f 100644
--- a/.github/workflows/container_release_unified.yml
+++ b/.github/workflows/container_release_unified.yml
@@ -223,5 +223,23 @@ jobs:
           
           echo "✓ Successfully copied ${{ matrix.variant }} to Docker Hub"
 
+  helm-release:
+    runs-on: ubuntu-latest
+    needs: [copy-to-dockerhub]
+    permissions:
+      contents: write
+      pages: write
+    steps:
+      - uses: actions/checkout@v6
+      - name: Publish Helm charts
+        uses: stefanprodan/helm-gh-pages@v1.7.0
+        with:          
+          token: ${{ secrets.GITHUB_TOKEN }}
+          charts_dir: k8s/charts
+          target_dir: helm
+          branch: gh-pages
+          helm_version: "3.18.4"
+
+
 
 
diff --git a/.github/workflows/helm_chart_release.yml b/.github/workflows/helm_chart_release.yml
deleted file mode 100644
index d21b00451..000000000
--- a/.github/workflows/helm_chart_release.yml
+++ /dev/null
@@ -1,23 +0,0 @@
-name: "helm: publish charts"
-on:
-  push:
-    tags:
-      - '*'
-
-permissions:
-  contents: write
-  pages: write
-
-jobs:
-  release:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
-      - name: Publish Helm charts
-        uses: stefanprodan/helm-gh-pages@v1.7.0
-        with:          
-          token: ${{ secrets.GITHUB_TOKEN }}
-          charts_dir: k8s/charts
-          target_dir: helm
-          branch: gh-pages
-          helm_version: "3.18.4"