From 6084e7670a129cb3f3408e6729dafb8e557d2ebf Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 13 Apr 2014 03:06:15 -0700 Subject: [PATCH] fix bug when reading back the replica settings! --- go/storage/replica_placement.go | 2 +- go/storage/replica_placement_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 go/storage/replica_placement_test.go diff --git a/go/storage/replica_placement.go b/go/storage/replica_placement.go index 55428749b..696888cd8 100644 --- a/go/storage/replica_placement.go +++ b/go/storage/replica_placement.go @@ -36,7 +36,7 @@ func NewReplicaPlacementFromString(t string) (*ReplicaPlacement, error) { } func NewReplicaPlacementFromByte(b byte) (*ReplicaPlacement, error) { - return NewReplicaPlacementFromString(fmt.Sprintf("%d", b)) + return NewReplicaPlacementFromString(fmt.Sprintf("%03d", b)) } func (rp *ReplicaPlacement) Byte() byte { diff --git a/go/storage/replica_placement_test.go b/go/storage/replica_placement_test.go new file mode 100644 index 000000000..9c2161e94 --- /dev/null +++ b/go/storage/replica_placement_test.go @@ -0,0 +1,14 @@ +package storage + +import ( + "testing" +) + +func TestReplicaPlacemnetSerialDeserial(t *testing.T) { + rp, _ := NewReplicaPlacementFromString("001") + new_rp, _ := NewReplicaPlacementFromByte(rp.Byte()) + if rp.String() != new_rp.String() { + println("expected:", rp.String(), "actual:", new_rp.String()) + t.Fail() + } +}