From 590e7efbefb74537572928163504f73cea6b6305 Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Wed, 28 Jan 2026 18:40:02 -0800 Subject: [PATCH] s3tables: Separate table name pattern constant for clarity Define a separate tableNamePatternStr constant for the table name component in the ARN regex, even though it currently has the same value as tableNamespacePatternStr. This improves code clarity and maintainability, making it easier to modify if the naming rules for tables and namespaces diverge in the future. --- weed/s3api/s3tables/utils.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/weed/s3api/s3tables/utils.go b/weed/s3api/s3tables/utils.go index 06ef3d8dd..cf009641e 100644 --- a/weed/s3api/s3tables/utils.go +++ b/weed/s3api/s3tables/utils.go @@ -14,11 +14,12 @@ import ( const ( bucketNamePatternStr = `[a-z0-9-]+` tableNamespacePatternStr = `[a-z0-9_]+` + tableNamePatternStr = `[a-z0-9_]+` ) var ( bucketARNPattern = regexp.MustCompile(`^arn:aws:s3tables:[^:]*:[^:]*:bucket/(` + bucketNamePatternStr + `)$`) - tableARNPattern = regexp.MustCompile(`^arn:aws:s3tables:[^:]*:[^:]*:bucket/(` + bucketNamePatternStr + `)/table/(` + tableNamespacePatternStr + `)/(` + tableNamespacePatternStr + `)$`) + tableARNPattern = regexp.MustCompile(`^arn:aws:s3tables:[^:]*:[^:]*:bucket/(` + bucketNamePatternStr + `)/table/(` + tableNamespacePatternStr + `)/(` + tableNamePatternStr + `)$`) ) // ARN parsing functions