From 568f1fe5b18e1006610aa931416b49a6ddccc1c1 Mon Sep 17 00:00:00 2001 From: cduk <19917266+cduk@users.noreply.github.com> Date: Wed, 31 Dec 2025 02:32:33 +0100 Subject: [PATCH] fix: include DiskType in metadata log volume assignment (#7918) When writing metadata logs to /topics/.system/log, the filer was not respecting the disk type configuration from path-specific rules (fs.configure). This caused volume assignment failures when volume servers used a specific disk type (e.g., "ssd") because the assign request defaulted to empty disk type. The fix adds DiskType to the VolumeAssignRequest in the filer's metadata log write path, ensuring that path-specific disk type configurations are properly honored for internal system writes. Fixes errors like: "metadata log write failed /topics/.system/log/...: AssignVolume: failed to find writable volumes for collection" Signed-off-by: Charles Darke Co-authored-by: Charles Darke --- weed/filer/filer_notify_append.go | 1 + 1 file changed, 1 insertion(+) diff --git a/weed/filer/filer_notify_append.go b/weed/filer/filer_notify_append.go index 9150f92d6..3efcc4fc9 100644 --- a/weed/filer/filer_notify_append.go +++ b/weed/filer/filer_notify_append.go @@ -55,6 +55,7 @@ func (f *Filer) assignAndUpload(targetFile string, data []byte) (*operation.Assi Count: 1, Collection: util.Nvl(f.metaLogCollection, rule.Collection), Replication: util.Nvl(f.metaLogReplication, rule.Replication), + DiskType: rule.DiskType, WritableVolumeCount: rule.VolumeGrowthCount, }